git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <johannes.schindelin@gmx.de>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] Fix 'git checkout <submodule>' to update the index
Date: Thu, 02 Apr 2009 12:54:17 -0700	[thread overview]
Message-ID: <7vprfuesra.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <c267451c12c4ead4c222eebe6df460b46edd59c1.1238678601u.git.johannes.schindelin@gmx.de> (Johannes Schindelin's message of "Thu, 2 Apr 2009 15:30:25 +0200 (CEST)")

Johannes Schindelin <johannes.schindelin@gmx.de> writes:

> While 'git checkout <submodule>' should not update the submodule's
> working directory, it should update the index.  This is in line with
> how submodules are handled in the rest of Git.
>
> While at it, test 'git reset [<commit>] <submodule>', too.
>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> ---
>
> 	I have no idea who thought that it would be a good idea to leave 
> 	the submodules alone, but I think it is highly counterintuitive 
> 	that
>
> 		git checkout <submodule>
>
> 	does not touch the index.

I do not see anything that treats submodule specially in the scripted
version and this check for S_ISGITLINK() has been there since the very
beginning of C rewrite 782c2d6 (Build in checkout, 2008-02-07), so it is a
regression fix that can go to maint (all the way down to 1.5.5 if you
want).

Thanks.

  reply	other threads:[~2009-04-02 19:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1238678601u.git.johannes.schindelin@gmx.de>
2009-04-02 13:30 ` [PATCH] Fix 'git checkout <submodule>' to update the index Johannes Schindelin
2009-04-02 19:54   ` Junio C Hamano [this message]
2009-04-02 20:27     ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vprfuesra.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=johannes.schindelin@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).