From: Junio C Hamano <gitster@pobox.com>
To: Deskin Miller <deskinm@gmail.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
git@vger.kernel.org, Jay Soffian <jaysoffian@gmail.com>
Subject: [PATCH] "git branch -M @{-1}"
Date: Thu, 26 Feb 2009 22:12:22 -0800 [thread overview]
Message-ID: <7vprh4o1bt.fsf_-_@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <7veixkpi4a.fsf@gitster.siamese.dyndns.org> (Junio C. Hamano's message of "Thu, 26 Feb 2009 21:24:21 -0800")
Earlier, we've taught "git branch -d <name>" that <name> is supposed to be
a branch name and not a random extended SHA-1. "git branch -m <name> [<name>]"
needs to be taught the same.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
builtin-branch.c | 14 ++++++++++----
1 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/builtin-branch.c b/builtin-branch.c
index c34af27..3f97838 100644
--- a/builtin-branch.c
+++ b/builtin-branch.c
@@ -425,21 +425,27 @@ static void rename_branch(const char *oldname, const char *newname, int force)
if (!oldname)
die("cannot rename the current branch while not on any.");
- strbuf_addf(&oldref, "refs/heads/%s", oldname);
+ if (interpret_nth_last_branch(oldname, &oldref) == strlen(oldname))
+ strbuf_splice(&oldref, 0, 0, "refs/heads/", 11);
+ else
+ strbuf_addf(&oldref, "refs/heads/%s", oldname);
if (check_ref_format(oldref.buf))
die("Invalid branch name: %s", oldref.buf);
- strbuf_addf(&newref, "refs/heads/%s", newname);
+ if (interpret_nth_last_branch(newname, &newref) == strlen(newname))
+ strbuf_splice(&newref, 0, 0, "refs/heads/", 11);
+ else
+ strbuf_addf(&newref, "refs/heads/%s", newname);
if (check_ref_format(newref.buf))
die("Invalid branch name: %s", newref.buf);
if (resolve_ref(newref.buf, sha1, 1, NULL) && !force)
- die("A branch named '%s' already exists.", newname);
+ die("A branch named '%s' already exists.", newref.buf + 11);
strbuf_addf(&logmsg, "Branch: renamed %s to %s",
- oldref.buf, newref.buf);
+ oldref.buf, newref.buf);
if (rename_ref(oldref.buf, newref.buf, logmsg.buf))
die("Branch rename failed");
next prev parent reply other threads:[~2009-02-27 6:15 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-14 7:08 [PATCH] teach the new "@{-1} syntax to "git branch" Junio C Hamano
2009-02-14 7:11 ` Jay Soffian
2009-02-14 7:21 ` Junio C Hamano
2009-02-14 9:37 ` [PATCH v2 1/2] Teach the " Junio C Hamano
2009-02-14 9:39 ` [PATCH v2 2/2] Teach @{-1} to git merge Junio C Hamano
2009-02-14 22:52 ` Johannes Schindelin
2009-02-15 2:05 ` Junio C Hamano
2009-02-15 2:32 ` Junio C Hamano
2009-02-15 9:24 ` Nanako Shiraishi
2009-02-15 10:02 ` Junio C Hamano
2009-02-15 11:21 ` Johannes Schindelin
2009-02-16 4:16 ` Junio C Hamano
2009-02-16 10:41 ` Johannes Schindelin
2009-02-16 16:40 ` Jay Soffian
2009-02-26 0:11 ` Junio C Hamano
2009-02-26 10:18 ` Johannes Schindelin
2009-02-27 4:27 ` Deskin Miller
2009-02-27 5:24 ` Junio C Hamano
2009-02-27 6:10 ` [PATCH] git-branch: a detached HEAD and branch called HEAD are different Junio C Hamano
2009-02-27 6:12 ` Junio C Hamano [this message]
2009-02-27 6:49 ` [PATCH] "git branch -M @{-1}" Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vprh4o1bt.fsf_-_@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=deskinm@gmail.com \
--cc=git@vger.kernel.org \
--cc=jaysoffian@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).