From: Junio C Hamano <gitster@pobox.com>
To: Thomas Rast <trast@student.ethz.ch>
Cc: git@vger.kernel.org
Subject: Re: [RFC/RFH] Fun things with git-notes, or: patch tracking backwards
Date: Tue, 10 Feb 2009 15:30:07 -0800 [thread overview]
Message-ID: <7vprhpkgzk.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <200902110012.34717.trast@student.ethz.ch> (Thomas Rast's message of "Wed, 11 Feb 2009 00:12:30 +0100")
Thomas Rast <trast@student.ethz.ch> writes:
> Junio C Hamano wrote:
>> Thomas Rast <trast@student.ethz.ch> writes:
>>
>> > I have imported all commits, and mails since roughly July 2008
>> > (starting with Gmane 89000). In this timeframe there were 1802
>> > non-merge commits, and the mailnotes tree now holds 1122 annotations.
>>
>> How do you match the mails to commits?
>>
>> I am curious what the right balance for the matching algorithm should be,
>> between being forgiving about amending of commit log message and the patch
>> text to fix minor typos and obvious bugs, and being strict not to cause
>> false matches to a message that contains the second iteration of the
>> patch, when what was committed was the first iteration.
>
> Right now it's just the patch-id. Maybe filtering (author,subject)
> and then picking the one that is the most similar could work.
Yeah, I actually was thinking about matching the (date, author) tuple and
nothing else, as it is unlikely you would have dups.
By the way, the note to f6b98e4 (git-web--browse: Fix check for
/bin/start, 2009-02-08) is interesting.
Ramsay's 104332 was the same as what ended up in the commit, but his
second patch that can be found by going to the thread from it is obviously
a better alternative. In short, I screwed up, by not recalling the
previous round. Sorry.
I find the "Extra-Notes:" tag a bit too loud, but I am probably a minority
who thinks everything but the Message-ID can be dropped, so please don't
take it as a feature request ;-)
next prev parent reply other threads:[~2009-02-10 23:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-09 14:08 [RFC/RFH] Fun things with git-notes, or: patch tracking backwards Thomas Rast
2009-02-09 16:19 ` SZEDER Gábor
2009-02-09 16:29 ` Thomas Rast
2009-02-09 17:49 ` tool and worktree Giuseppe Bilotta
2009-02-10 22:42 ` [RFC/RFH] Fun things with git-notes, or: patch tracking backwards Thomas Rast
2009-02-10 22:52 ` Junio C Hamano
2009-02-10 22:59 ` Junio C Hamano
2009-02-10 23:12 ` Thomas Rast
2009-02-10 23:30 ` Junio C Hamano [this message]
2009-02-11 22:52 ` Thomas Rast
2009-02-11 22:58 ` Thomas Rast
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vprhpkgzk.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).