From: Junio C Hamano <gitster@pobox.com>
To: Pascal Obry <pascal@obry.net>
Cc: gitzilla@gmail.com, Steffen Prohaska <prohaska@zib.de>,
git@vger.kernel.org
Subject: Re: 026fa0d5ad Breaks installs with absolue $(gitexecdir) and $(template_dir) variables using older GNU makes
Date: Thu, 05 Feb 2009 00:01:11 -0800 [thread overview]
Message-ID: <7vprhxgvnc.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <7vvdrpgvzl.fsf@gitster.siamese.dyndns.org> (Junio C. Hamano's message of "Wed, 04 Feb 2009 23:53:50 -0800")
Junio C Hamano <gitster@pobox.com> writes:
> Regardless, I think your patch to config.mak is independently good,
> because the way Makefile defines these directories is without the trailing
> slash, and it would be better to be consistent.
In other words, I am thinking about applying your patch after amending the
log message like this.
[PATCH] config.mak.in: define paths without trailing slash
The main Makefile defines gitexecdir and template_dir without trailing
slash. config.mak.in should do the same to be consistent.
Signed-off-by: Pascal Obry <pascal@obry.net>
I think the misuse of abspath is a separate issue.
The main Makefile should be made robust not to misdetect the relative vs
absolute, especially because not everybody uses config.mak.autogen, and
because people should be able to override these variables from the command
line of make invocation and the name of the directory with or without
trailing slash ought to mean the same thing.
next prev parent reply other threads:[~2009-02-05 8:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-01 18:24 026fa0d5ad Breaks installs with absolue $(gitexecdir) and $(template_dir) variables using older GNU makes A Large Angry SCM
2009-02-05 7:04 ` Junio C Hamano
2009-02-05 7:13 ` Steffen Prohaska
2009-02-05 7:35 ` Junio C Hamano
2009-02-05 7:38 ` Pascal Obry
2009-02-05 7:53 ` Junio C Hamano
2009-02-05 7:57 ` Pascal Obry
2009-02-05 8:01 ` Junio C Hamano [this message]
2009-02-05 7:44 ` Junio C Hamano
2009-02-05 8:18 ` [PATCH] Makefile: fix misdetection of relative pathnames Junio C Hamano
2009-02-05 12:27 ` Johannes Sixt
2009-02-05 17:19 ` Junio C Hamano
2009-02-05 22:16 ` A Large Angry SCM
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vprhxgvnc.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitzilla@gmail.com \
--cc=pascal@obry.net \
--cc=prohaska@zib.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).