From: Junio C Hamano <gitster@pobox.com>
To: jidanni@jidanni.org
Cc: barkalow@iabervon.org, git@vger.kernel.org
Subject: Re: stopping patches from just floating by
Date: Sun, 11 Jan 2009 15:06:17 -0800 [thread overview]
Message-ID: <7vprito32u.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <874p05k1ie.fsf@jidanni.org> (jidanni@jidanni.org's message of "Mon, 12 Jan 2009 04:53:45 +0800")
jidanni@jidanni.org writes:
> I see. Say, for my forthcoming 40 minor grammar fixes that affect 20
> files in Documentation/*, I just couldn't bear spamming this list with
> more that one or two [PATCH] mails. OK one long mail it will be then,
> with several commits encompassing many diffs. Hope that will be OK.
It probably won't be Ok, as earlier documentation patches from you that
were smaller had good bits that were applied and not so good bits that
were dropped, and I'd refuse to pick and choose only good bits from one
single large patch myself. The tradeoff between "minor grammar fixes" and
my time spent to do so is not good enough.
Please send in small isolated pieces so that people do not have to comment
"in this patch, this and that rewordings are very good clarification, but
this other hunk adds noise without adding much signal".
And by "isolated", I do not mean "one mail per patched file".
For example, if you fix many misused 3rd person singular verbs that ends
with 's' that are used for subject that is not 3rd person singular, that
is one topic and one patch can fix an error of that kind in all of 20
files.
On the other hand, if you conflate such a fix with a new explanation of an
option (which may or may not be adding more noise than the signal) to the
same file in a single e-mailed patch, you will force people to say "this
part is good but that part is not". That's not the isolation I am
referring to.
next prev parent reply other threads:[~2009-01-11 23:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-11 17:27 stopping patches from just floating by jidanni
2009-01-11 20:37 ` Daniel Barkalow
2009-01-11 20:53 ` jidanni
2009-01-11 23:06 ` Junio C Hamano [this message]
2009-01-12 2:51 ` grammar patches not best use of talent jidanni
2009-01-12 8:54 ` jdelstrother
2009-01-12 9:35 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vprito32u.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
--cc=jidanni@jidanni.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).