git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Dotan Barak <dotanba@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Rename dynamic memory allocation functions to their "x" version
Date: Tue, 09 Sep 2008 21:11:42 -0700	[thread overview]
Message-ID: <7vprnczlkx.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <200809092157.10185.dotanba@gmail.com> (Dotan Barak's message of "Tue, 9 Sep 2008 21:57:10 +0300")

Dotan Barak <dotanba@gmail.com> writes:

> In places that the standard malloc/strdup is used without checking
> if the allocation was successful, I replaced it to xmalloc/xstrdup
> which check the memory allocation result.
>
> Signed-off-by: Dotan Barak <dotanba@gmail.com>

Looks good.  Will apply, but I'd retitle it (it is not "rename").

Thanks.

  reply	other threads:[~2008-09-10  4:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-09 18:57 [PATCH] Rename dynamic memory allocation functions to their "x" version Dotan Barak
2008-09-10  4:11 ` Junio C Hamano [this message]
2008-09-10  6:02   ` Dotan Barak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vprnczlkx.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=dotanba@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).