git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH 3/3] Enable parallel tests
Date: Fri, 08 Aug 2008 01:28:21 -0700	[thread overview]
Message-ID: <7vprojgbbu.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <489BF95F.1070000@lsrfire.ath.cx> (René Scharfe's message of "Fri, 08 Aug 2008 09:44:31 +0200")

René Scharfe <rene.scharfe@lsrfire.ath.cx> writes:

> test="trash directory/$this_test"?
>
> The advantage would be that all trash was still inside "trash
> directory".  Not sure if the extra directory level would break
> something.  (Note: $this_test is defined a bit later in the script.)

The extra directory level may break some tests that refer to their
precomputed test vectors in ../tXXXX, but I think they should be fixed
regardless.  That's what $TEST_DIRECTORY is for.

I'd very much prefer having 't/trash directory/t1234-test-name/' so that
we can say "make clean" to clean "t/trash directory" in one go.

  reply	other threads:[~2008-08-08  8:29 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-08  5:59 [PATCH 0/3] Enable parallelized tests Johannes Schindelin
2008-08-08  5:59 ` [PATCH 1/3] t9700: remove useless check Johannes Schindelin
2008-08-08  5:59 ` [PATCH 2/3] tests: Clarify dependencies between tests, 'aggregate-results' and 'clean' Johannes Schindelin
2008-08-08  5:59 ` [PATCH 3/3] Enable parallel tests Johannes Schindelin
2008-08-08  6:52   ` Junio C Hamano
2008-08-08 10:26     ` Johannes Schindelin
2008-08-08 10:33       ` Junio C Hamano
2008-08-08  7:44   ` René Scharfe
2008-08-08  8:28     ` Junio C Hamano [this message]
2008-08-08  9:31       ` [PATCH] tests: use $TEST_DIRECTORY to refer to the t/ directory Junio C Hamano
2008-08-08 10:35         ` Johannes Schindelin
2008-08-08 10:40           ` Junio C Hamano
2008-08-08 14:40             ` Stephan Beyer
2008-08-09 22:53         ` Olivier Marin
2008-08-09 23:20           ` Junio C Hamano
2008-08-10  7:33           ` Junio C Hamano
2008-08-08 10:37     ` [PATCH 3/3] Enable parallel tests Johannes Schindelin
2008-08-08 11:08       ` [PATCH 3/3 v2] " Johannes Schindelin
2008-08-08 15:03         ` Stephan Beyer
2008-08-08 15:27           ` Johannes Schindelin
2008-08-08 15:36 ` [PATCH 0/3] Enable parallelized tests SZEDER Gábor
2008-08-08 16:02   ` Stephan Beyer
2008-08-08 16:30     ` Johannes Schindelin
2008-08-08 16:33       ` Stephan Beyer
2008-08-08 16:51         ` Johannes Schindelin
2008-08-08 16:56           ` Stephan Beyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vprojgbbu.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=rene.scharfe@lsrfire.ath.cx \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).