From: Junio C Hamano <gitster@pobox.com>
To: Christian Couder <chriscool@tuxfamily.org>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Michael Haggerty <mhagger@alum.mit.edu>,
Jeff King <peff@peff.net>,
git@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] bisect: error out when given any good rev that is not an ancestor of the bad rev
Date: Mon, 30 Jun 2008 16:32:00 -0700 [thread overview]
Message-ID: <7vprpyts7j.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <200807010116.30214.chriscool@tuxfamily.org> (Christian Couder's message of "Tue, 1 Jul 2008 01:16:30 +0200")
Christian Couder <chriscool@tuxfamily.org> writes:
> Le mardi 1 juillet 2008, Junio C Hamano a écrit :
>> Christian Couder <chriscool@tuxfamily.org> writes:
>> > Before this patch "git bisect" doesn't really work when it is given
>> > some good revs that are siblings of the bad rev.
>> >
>> > For example if there is the following history:
>> >
>> > A-B-C-D
>> > \E-F
>> >
>> > and we launch "git bisect start D F" then only C and D will be
>> > considered as possible first bad commit.
>
> I am assuming the first bad commit in the graph is A and it is fixed by F.
Ah, I see your confusion here. bisect is about finding regressions.
"Older ones were good, and now there is a breakage. Who broke it?"
If F fixed it, that is already outside the bisection's scope. The user
needs to know that by saying F is good, he is saying he knows everything
that leads to F is good.
next prev parent reply other threads:[~2008-06-30 23:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-30 22:42 [PATCH] bisect: error out when given any good rev that is not an ancestor of the bad rev Christian Couder
2008-06-30 22:44 ` Junio C Hamano
2008-06-30 22:48 ` Junio C Hamano
2008-06-30 23:16 ` Christian Couder
2008-06-30 23:27 ` Junio C Hamano
2008-06-30 23:32 ` Junio C Hamano [this message]
2008-06-30 23:42 ` Junio C Hamano
2008-06-30 23:46 ` Christian Couder
2008-06-30 23:52 ` Junio C Hamano
2008-07-01 0:20 ` Christian Couder
2008-07-01 1:13 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vprpyts7j.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=mhagger@alum.mit.edu \
--cc=peff@peff.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).