git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 3/3 v2] Make "git-remote rm" delete refs acccording to fetch specs
Date: Sat, 31 May 2008 22:29:29 -0700	[thread overview]
Message-ID: <7vprr1d8p2.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 20080601042804.GA32293@spearce.org

"Shawn O. Pearce" <spearce@spearce.org> writes:

>  This is a longer, but better version of this patch.  Instead of
>  blindly deleting the refs we remove them only if this is the last
>  remote that would write to the local tracking ref.

If this is a better version than the previous one, then probably "git
remote prune" patch to unconditionally remove ones that do not exist in
one of the remotes that fetch into the tracking namespace also needs to be
rethought, doesn't it?  Another remote may still have it but you obviously
do not know that until you check.

Admittedly, next fetch from the other remote may or may not resurrect them
and either way it is not a big deal.

I think this is exactly the same issue as this improvement in [3/3] deals
with.  If "git remote rm" of one remote removed the shared tracked refs,
next fetch from the other remote would resurrect them if the other remote
still exists.  It may probably feel better to be extra careful like this
improved patch, but I doubt it would matter in practice.  After all,
people who creates such a configuration would know what they are doing.

  parent reply	other threads:[~2008-06-01  5:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-01  3:59 [PATCH 3/3] Make "git-remote rm" delete refs acccording to fetch specs Shawn O. Pearce
2008-06-01  4:28 ` [PATCH 3/3 v2] " Shawn O. Pearce
2008-06-01  4:40   ` Shawn O. Pearce
2008-06-01  5:29   ` Junio C Hamano [this message]
2008-06-01  6:30     ` Shawn O. Pearce
2008-06-01  8:28       ` Junio C Hamano
2008-06-02 17:10       ` Jon Loeliger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vprr1d8p2.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).