From: Junio C Hamano <gitster@pobox.com>
To: "Ping Yin" <pkufranky@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v3 1/4] config.c: Add git_config_bool_or_int to handle bool/int variable
Date: Sun, 13 Apr 2008 02:03:43 -0700 [thread overview]
Message-ID: <7vprsucej4.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <46dff0320804130030q19dd9f23j66d9b7adc7d305d3@mail.gmail.com> (Ping Yin's message of "Sun, 13 Apr 2008 15:30:28 +0800")
"Ping Yin" <pkufranky@gmail.com> writes:
>> return git_config_int(name, value) != 0;
>> }
>
> Should return an interger if *is_bool==0
> s/!=0//
Yeah, you are right. I do not know where that "!= 0" came from.
next prev parent reply other threads:[~2008-04-13 9:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-12 15:05 [PATCH v3 0/4] builtin-status: submodule summary support Ping Yin
2008-04-12 15:05 ` [PATCH v3 1/4] config.c: Add git_config_bool_or_int to handle bool/int variable Ping Yin
2008-04-12 15:05 ` [PATCH v3 2/4] git-submodule summary: --for-status option Ping Yin
2008-04-12 15:05 ` [PATCH v3 3/4] builtin-status: submodule summary support Ping Yin
2008-04-12 15:05 ` [PATCH v3 4/4] buitin-status: Add tests for submodule summary Ping Yin
2008-04-12 15:13 ` Ping Yin
2008-04-13 6:26 ` [PATCH v3 1/4] config.c: Add git_config_bool_or_int to handle bool/int variable Junio C Hamano
2008-04-13 7:28 ` Ping Yin
2008-04-13 7:30 ` Ping Yin
2008-04-13 9:03 ` Junio C Hamano [this message]
2008-04-13 19:14 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vprsucej4.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=pkufranky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).