git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Pierre Habouzit <madcoder@debian.org>
Cc: Git ML <git@vger.kernel.org>
Subject: Re: [PATCH] git-quiltimport: better parser to  grok "enhanced"  series files.
Date: Sun, 09 Mar 2008 03:17:18 -0700	[thread overview]
Message-ID: <7vpru4p5g1.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080309095918.GA23924@artemis.madism.org> (Pierre Habouzit's message of "Sun, 09 Mar 2008 10:59:19 +0100")

Pierre Habouzit <madcoder@debian.org> writes:

>> You made the loop a subshell but I think you can redirect into the while
>> loop without an extra "cat" process.
>
> Well probably yeah, I could use an exec -- < series or an alike trick
> for sure.

It seems many people forget that it is perfectly fine to redirect into
while loop itself, like

	while read foo bar
        do
        	do a lot of stuff
	done <input-file

>> Can a patch name contain $IFS whitespace characters?
>
>   I tested and quilt says that:
>
> $ quilt new a\ b.patch
> Patch a is now on top
>
> And when I quilt refresh it, it creates a patch named 'a'.  (and yes, I thought
> of this and tested it prior to sending the patch).
>
>> If so, this patch would regress them.  Otherwise it looks fine.

Ok, somehow in an earlier patch to quiltimport I picked up an incorrect
notion that they could contain a blank, but then that's fine.

Will queue, but I am very well into my merge binge for tonight (and it
hasn't finished even though it is past 3 AM, sheesh), so it will be in the
next round.

  reply	other threads:[~2008-03-09 10:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-08 18:27 [PATCH] git-quiltimport: better parser to grok "enhanced" series files Pierre Habouzit
2008-03-09  3:39 ` Junio C Hamano
2008-03-09  9:59   ` Pierre Habouzit
2008-03-09 10:17     ` Junio C Hamano [this message]
2008-03-09 11:27       ` Pierre Habouzit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vpru4p5g1.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=madcoder@debian.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).