git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] allow git-am to run in a subdirectory
Date: Fri, 29 Feb 2008 23:38:55 -0800	[thread overview]
Message-ID: <7vprue6ghc.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080301062255.GA27538@coredump.intra.peff.net> (Jeff King's message of "Sat, 1 Mar 2008 01:22:55 -0500")

Jeff King <peff@peff.net> writes:

> I can't imagine anyone would be confused by this behavior.

As long as you do not lose sight of the mailbox parameter by chdir'ing
around, I am Ok with the patch.

... and after I started writing that, I find...

> ...
> It will fail to find your mbox file if you specified a relative path
> and it had to change directories. I don't know if that case is worth
> handling.

Hmmm ;-).


  reply	other threads:[~2008-03-01  7:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-01  6:22 [PATCH] allow git-am to run in a subdirectory Jeff King
2008-03-01  7:38 ` Junio C Hamano [this message]
2008-03-01  8:12   ` Jeff King
2008-03-01  8:15     ` Junio C Hamano
2008-03-01  8:20       ` Jeff King
2008-03-03  3:26     ` Jay Soffian
2008-03-03  6:46     ` Re* " Junio C Hamano
2008-03-03  6:58       ` Jeff King
2008-03-03  7:08         ` Junio C Hamano
2008-03-03 11:53           ` Johannes Schindelin
2008-03-03 17:01             ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vprue6ghc.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).