git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Remi Vanicat <vanicat@debian.org>
Cc: julliard@winehq.org, git@vger.kernel.org
Subject: Re: [PATCH] git.el: find the git-status buffer whatever its name is
Date: Thu, 28 Feb 2008 12:14:33 -0800	[thread overview]
Message-ID: <7vprugj0t2.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <87skzd44qn.dlv@maison.homelinux.org> (Remi Vanicat's message of "Thu, 28 Feb 2008 13:58:40 +0100")

Remi Vanicat <vanicat@debian.org> writes:

> Any comment on this bug fix ? It seem it was forgotten.
> I re-include it for convenience:

It is very cumbersome to apply if you "include everything
inside", so please don't do this.

Instead, send as if it is a new patch, adding Acked-by: by Alexandre
after your Signed-off-by: line.

> From 8ab57162a69c178dbc04bc4f94271e36ee9d120a Mon Sep 17 00:00:00 2001
> From: Rémi Vanicat <vanicat@debian.org>
> Date: Fri, 22 Feb 2008 22:36:23 +0100
> Subject: [PATCH] git.el: find the git-status buffer whatever its name is
>
> git-status used the buffer name to find git-status buffers, and that
> could failed if the buffer had another name, for example when multiple
> working directories was tracked.
> ---
>  contrib/emacs/git.el |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/contrib/emacs/git.el b/contrib/emacs/git.el
> index f69b697..14a1601 100644
> --- a/contrib/emacs/git.el
> +++ b/contrib/emacs/git.el
> @@ -1545,7 +1545,7 @@ Commands:
>          (with-current-buffer buffer
>            (when (and list-buffers-directory
>                       (string-equal fulldir (expand-file-name list-buffers-directory))
> -                     (string-match "\\*git-status\\*$" (buffer-name buffer)))
> +		     (eq major-mode 'git-status-mode))
>              (setq found buffer))))
>        (setq list (cdr list)))
>      found))
> -- 
> 1.5.4.2.191.g7b407
>
>
> -- 
> Rémi Vanicat

  parent reply	other threads:[~2008-02-28 20:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-22 21:45 [PATCH] git.el: find the git-status buffer whatever its name is Rémi Vanicat
2008-02-28 12:58 ` Remi Vanicat
2008-02-28 14:03   ` Alexandre Julliard
2008-02-28 20:14   ` Junio C Hamano [this message]
2008-02-29 18:28     ` Rémi Vanicat
2008-02-29  2:00   ` Xavier Maillard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vprugj0t2.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=julliard@winehq.org \
    --cc=vanicat@debian.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).