Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: William Morgan <wmorgan-git@masanjin.net>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: git-walkthrough-add script
Date: Fri, 04 Jan 2008 18:50:08 -0800	[thread overview]
Message-ID: <7vprwhf0kf.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1199500441-sup-4067@south> (William Morgan's message of "Fri, 04 Jan 2008 18:37:34 -0800")

William Morgan <wmorgan-git@masanjin.net> writes:

> Excerpts from Jeff King's message of Fri Jan 04 13:07:51 -0800 2008:
>> But if you have interface improvement suggestions for "git-add -i" or
>> "git-add -p", I'm sure they would be well-received (post-1.5.4
>> release, of course).
>
> Not to show off my git newbness any more than necessary, but when I run
> both git-add -i and git-add -p, I see exactly the same output and
> interface. Are they meant to be different?

They are meant to be different.

    $ git reset --hard
    $ echo >>Makefile
    $ echo >>psql/Makefile
    $ git add -p
    diff --git a/Makefile b/Makefile
    index a2177bc..eb250b0 100644
    --- a/Makefile
    +++ b/Makefile
    @@ -54,3 +54,4 @@ snapdiff ::
            latest=`ls -1dr $(_snap)/release-????-??-?? | head -n 1` &&
            \
            diff -X dontdiff -ru "$$latest" .

    +
    Stage this hunk [y/n/a/d/?]? ^C

    $ git add -i
               staged     unstaged path
      1:    unchanged        +1/-0 Makefile
      2:    unchanged        +1/-0 psql/Makefile

    *** Commands ***
      1: [s]tatus     2: [u]pdate     3: [r]evert     4: [a]dd
      untracked
      5: [p]atch      6: [d]iff       7: [q]uit       8: [h]elp
    What now> ^C

There may be something broken with your git installation.

  reply	other threads:[~2008-01-05  2:50 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-04  6:14 git-walkthrough-add script William Morgan
2008-01-04  7:26 ` Jeff King
2008-01-04 18:31   ` William Morgan
2008-01-04 21:07     ` Jeff King
2008-01-05  2:37       ` William Morgan
2008-01-05  2:50         ` Junio C Hamano [this message]
2008-01-05  2:55           ` Junio C Hamano
2008-01-05  3:02             ` William Morgan
2008-01-05  4:08           ` Pedro Melo
2008-01-04 23:26 ` Pedro Melo
2008-01-04 23:28   ` Junio C Hamano
2008-01-05  0:02   ` William Morgan
2008-01-05  0:17     ` Pedro Melo
2008-01-05  1:00   ` Miklos Vajna
2008-01-05  2:54     ` William Morgan
2008-01-05  3:43       ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vprwhf0kf.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=wmorgan-git@masanjin.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox