From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Cc: Carlos Rica <jasampler@gmail.com>
Subject: [PATCH] "git-tag -s" should create a signed annotated tag
Date: Sun, 25 Nov 2007 15:21:42 -0800 [thread overview]
Message-ID: <7vprxxj4hl.fsf@gitster.siamese.dyndns.org> (raw)
The earlier patch 396865859918e9c7bf8ce74aae137c57da134610 (Make
builtin-tag.c use parse_options.) broke "git-tag -s".
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
* It's _very_ disturbing that the testsuite did not catch this
breakage, even though I though we had a very detailed coverage for
"git tag" when it was rewritten in C.
builtin-tag.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/builtin-tag.c b/builtin-tag.c
index 3a6467d..114c684 100644
--- a/builtin-tag.c
+++ b/builtin-tag.c
@@ -398,6 +398,9 @@ int cmd_tag(int argc, const char **argv, const char *prefix)
argc = parse_options(argc, argv, options, git_tag_usage, 0);
+ if (sign)
+ annotate = 1;
+
if (list)
return list_tags(list == no_pattern ? NULL : list, lines);
if (delete)
next reply other threads:[~2007-11-25 23:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-25 23:21 Junio C Hamano [this message]
2007-11-26 4:50 ` [PATCH] "git-tag -s" should create a signed annotated tag Jeff King
2007-11-26 4:51 ` Carlos Rica
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vprxxj4hl.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jasampler@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).