From mboxrd@z Thu Jan 1 00:00:00 1970 From: Junio C Hamano Subject: Re: [PATCH] Git.pm: Don't return 'undef' in vector context. Date: Fri, 16 Nov 2007 16:39:48 -0800 Message-ID: <7vpry9wvqj.fsf@gitster.siamese.dyndns.org> References: <473D3593.9080806@zwell.net> <7vfxz61yox.fsf@gitster.siamese.dyndns.org> <473D4E18.3060006@zwell.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Git Mailing List To: Dan Zwell X-From: git-owner@vger.kernel.org Sat Nov 17 01:40:15 2007 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1ItBjJ-0002Jr-GG for gcvg-git-2@gmane.org; Sat, 17 Nov 2007 01:40:13 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761968AbXKQAj5 (ORCPT ); Fri, 16 Nov 2007 19:39:57 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761084AbXKQAj4 (ORCPT ); Fri, 16 Nov 2007 19:39:56 -0500 Received: from sceptre.pobox.com ([207.106.133.20]:59755 "EHLO sceptre.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757470AbXKQAj4 (ORCPT ); Fri, 16 Nov 2007 19:39:56 -0500 Received: from sceptre (localhost.localdomain [127.0.0.1]) by sceptre.pobox.com (Postfix) with ESMTP id 809E92EF; Fri, 16 Nov 2007 19:40:17 -0500 (EST) Received: from pobox.com (ip68-225-240-77.oc.oc.cox.net [68.225.240.77]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by sceptre.sasl.smtp.pobox.com (Postfix) with ESMTP id 0C02D9651F; Fri, 16 Nov 2007 19:40:13 -0500 (EST) In-Reply-To: <473D4E18.3060006@zwell.net> (Dan Zwell's message of "Fri, 16 Nov 2007 02:00:24 -0600") User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) Sender: git-owner@vger.kernel.org Precedence: bulk X-Mailing-List: git@vger.kernel.org Archived-At: Dan Zwell writes: > That's reasonable. I'll resend this as part of the > git-add--interactive color patches. This can be cherry-picked out, but > some of the other stuff I want to do depends on it (a helper function > that I wrote, config_with_default($repo, $key, $default)). Sure; as long as the "Don't return 'undef'" remains a separate patch early in the series, that is easy to manage. Thanks.