From: Junio C Hamano <gitster@pobox.com>
To: Alex Riesen <raa.lkml@gmail.com>
Cc: Guido Ostkamp <git@ostkamp.fastmail.fm>, git@vger.kernel.org
Subject: Re: [PATCH] Fix Solaris Workshop Compiler issues
Date: Wed, 14 Nov 2007 13:25:13 -0800 [thread overview]
Message-ID: <7vprycfrk6.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20071114204732.GE3973@steel.home> (Alex Riesen's message of "Wed, 14 Nov 2007 21:47:32 +0100")
Alex Riesen <raa.lkml@gmail.com> writes:
> Guido Ostkamp, Wed, Nov 14, 2007 21:31:13 +0100:
>> ...
>> cc: acomp failed for diff-delta.c
>> make: *** [diff-delta.o] Error 2
>>
>> This is because 'struct delta_index' is declared with no size in delta.h
>> and with size in diff-delta.c which does not fit.
>
> Huh?! Ever heard of forward declaration?
We are not the first people who pass around a pointer to an
opaque struct in the API to hide away the implementation. It
would be surprising if the Workshop Compiler chokes on this and
not other projects.
next prev parent reply other threads:[~2007-11-14 21:25 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-14 20:31 [PATCH] Fix Solaris Workshop Compiler issues Guido Ostkamp
2007-11-14 20:47 ` Alex Riesen
2007-11-14 21:25 ` Junio C Hamano [this message]
2007-11-14 23:21 ` Guido Ostkamp
2007-11-14 23:28 ` Alex Riesen
2007-11-15 0:17 ` Björn Steinbrink
2007-11-15 0:30 ` Junio C Hamano
2007-11-15 0:44 ` Björn Steinbrink
2007-11-15 0:46 ` Junio C Hamano
2007-11-15 0:50 ` Björn Steinbrink
2007-11-15 1:15 ` [PATCH] Fix "identifier redeclared" compilation error with SUN cc Björn Steinbrink
2007-11-15 22:00 ` Guido Ostkamp
2007-11-15 22:15 ` Junio C Hamano
2007-11-15 22:28 ` Guido Ostkamp
2007-11-16 18:59 ` [PATCH] Add mkdtemp() workaround for Sun Solaris 10 Guido Ostkamp
2007-11-17 0:33 ` [RFH] Solaris portability Junio C Hamano
2007-11-18 12:08 ` Guido Ostkamp
2007-11-18 17:46 ` Junio C Hamano
2007-11-16 4:58 ` [PATCH] Fix "identifier redeclared" compilation error with SUN cc Junio C Hamano
2007-11-16 12:55 ` Björn Steinbrink
2007-11-19 17:51 ` Guido Ostkamp
2007-11-20 8:30 ` Junio C Hamano
2007-11-20 17:28 ` Guido Ostkamp
2007-11-20 18:06 ` Guido Ostkamp
2007-11-20 18:26 ` Martin Mares
2007-11-20 20:08 ` Junio C Hamano
2007-11-20 20:09 ` Martin Mares
2007-11-15 0:44 ` [PATCH] Fix Solaris Workshop Compiler issues Linus Torvalds
2007-11-15 1:21 ` David Kastrup
2007-11-15 1:53 ` Linus Torvalds
2007-11-15 3:27 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vprycfrk6.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@ostkamp.fastmail.fm \
--cc=git@vger.kernel.org \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).