git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Daniel Barkalow <barkalow@iabervon.org>
Cc: git@vger.kernel.org
Subject: Re: Obscure commit message formatting issue
Date: Sun, 11 Nov 2007 14:01:36 -0800	[thread overview]
Message-ID: <7vprygbfwf.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0711111559220.29952@iabervon.org> (Daniel Barkalow's message of "Sun, 11 Nov 2007 16:28:19 -0500 (EST)")

Daniel Barkalow <barkalow@iabervon.org> writes:

> The current code drops extra blank lines between the first line of a 
> commit message (the summary line) and the remainder.

The patch application side does even more.  It not just strips
off the leading or trailing blank lines, but duplicate blank
lines in the middle and trailing whitespaces at the end of each
line.

I am of two minds about the formatting side.

The behaviour you found does not go far enough to correct all of
the above whitespace breakage the application side will fix up
on the generation side -- it only corrects one of them.  We
might want to do more, instead of less that you seem to be
implying to favor.

  reply	other threads:[~2007-11-11 22:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-11 21:28 Obscure commit message formatting issue Daniel Barkalow
2007-11-11 22:01 ` Junio C Hamano [this message]
2007-11-11 22:30   ` Daniel Barkalow
2007-11-11 22:43     ` Johannes Schindelin
2007-11-11 22:50       ` Daniel Barkalow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vprygbfwf.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=barkalow@iabervon.org \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).