git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: Steven Grimm <koreth@midwinter.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/2] Add --ignore-notfound option to exit with zero status when no files are removed.
Date: Mon, 16 Apr 2007 00:59:35 -0700	[thread overview]
Message-ID: <7vps64vjfc.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20070416075324.GA18961@midwinter.com> (Steven Grimm's message of "Mon, 16 Apr 2007 00:53:24 -0700")

Steven Grimm <koreth@midwinter.com> writes:

>  Documentation/git-rm.txt |    3 +++
>  builtin-rm.c             |   21 +++++++++++++++++----
>  t/t3600-rm.sh            |    4 ++++
>  3 files changed, 24 insertions(+), 4 deletions(-)

I find it easier to see what is going on with two independent
features separated out, especially with tests.  Much nicer.

> @@ -47,6 +47,9 @@ OPTIONS
>  	the paths only from the index, leaving working tree
>  	files.
>  
> +\--ignore-notfound::
> +	Exit with a zero status even if no files matched.
> +

ls-files has --error-unmatch so we may want to make the name
consistent by saying --ignore-unmatch?  I particularly do not
care about the minute naming issues _right_ _now_, but we might
regret it in the long run.

No need to resend unless you have an actual fix; I'll queue your
patch as is in 'pu', wait for a few days for comments on the
naming, and amend it as needed.

Thanks.

  reply	other threads:[~2007-04-16  7:59 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-16  0:04 [PATCH] Add -q option to "git rm" to suppress output when there aren't errors Steven Grimm
2007-04-16  0:13 ` Junio C Hamano
2007-04-16  0:17   ` Steven Grimm
2007-04-16  1:14     ` Junio C Hamano
2007-04-16  7:46       ` [PATCH 1/2] Add --quiet option to suppress output of "rm" commands for removed files Steven Grimm
2007-04-16  7:53         ` [PATCH 2/2] Add --ignore-notfound option to exit with zero status when no files are removed Steven Grimm
2007-04-16  7:59           ` Junio C Hamano [this message]
2007-04-16  8:13             ` Steven Grimm
2007-04-16  8:50             ` Jeff King
2007-04-16  8:53               ` Junio C Hamano
2007-04-16  9:04                 ` Jeff King
2007-04-16 18:29                   ` Josef Weidendorfer
2007-04-16  8:12           ` Steven Grimm
2007-04-16  7:54       ` [PATCH] Add -q option to "git rm" to suppress output when there aren't errors Alex Riesen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vps64vjfc.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=git@vger.kernel.org \
    --cc=koreth@midwinter.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).