git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: bonzini@gnu.org
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-fetch, git-parse-remote: Cleanup implementation of '.'
Date: Fri, 16 Mar 2007 02:32:19 -0700	[thread overview]
Message-ID: <7vps79v8ik.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: 45FA5771.1040200@lu.unisi.ch

Paolo Bonzini <paolo.bonzini@lu.unisi.ch> writes:

> 	The patch is a cleanup of the one you posted, and it was
> 	appropriately tested with no regression.
>
> 	I can see now what you meant by the split between fetch and
> 	merge logic making my patch more complicated than necessary.

Thanks.  I'll squash the two and apply.

> +	builtin)
> +	        canon_refs_list_for_fetch -d "$1" \
> +			$(git-show-ref | sed -n 's,.*[      ]\(refs/.*\),\1:,p') ;;

I may not be really thinking straight tonight (no I am not
drunk, but just a tad sick), but I wonder if this is sufficient?

	$(git-for-each-ref --format='%(refname):')

Shorter and one less process and pipe.

  reply	other threads:[~2007-03-16  9:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-15  8:23 [PATCH, fixed] git-fetch, git-branch: Support local --track via a special remote `.' Paolo Bonzini
2007-03-16  0:21 ` Junio C Hamano
2007-03-16  8:38   ` [PATCH] git-fetch, git-parse-remote: Cleanup implementation of '.' Paolo Bonzini
2007-03-16  9:32     ` Junio C Hamano [this message]
2007-03-16  9:38       ` Paolo Bonzini
2007-03-16 10:00         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vps79v8ik.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=bonzini@gnu.org \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).