From: Junio C Hamano <junkio@cox.net>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] prepare_packed_git(): sort packs by age and localness.
Date: Sat, 10 Mar 2007 19:07:13 -0800 [thread overview]
Message-ID: <7vps7gxyu6.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20070311023422.GE10343@spearce.org> (Shawn O. Pearce's message of "Sat, 10 Mar 2007 21:34:22 -0500")
"Shawn O. Pearce" <spearce@spearce.org> writes:
> Junio C Hamano <junkio@cox.net> wrote:
>> When accessing objects, we first look for them in packs that
>> are linked together in the reverse order of discovery.
>>
>> Since younger packs tend to contain more recent objects, which
>> are more likely to be accessed often, and local packs tend to
>> contain objects more relevant to our specific projects, sort the
>> list of packs before starting to access them. In addition,
>> favoring local packs over the ones borrowed from alternates can
>> be a win when alternates are mounted on network file systems.
>
> ACK. But...
>
>> diff --git a/cache.h b/cache.h
>> @@ -431,6 +432,7 @@ extern off_t find_pack_entry_one(const unsigned char *, struct packed_git *);
>> +void rearrange_packed_git(void);
>
> Is that really necessary to make public?
The next patch in the series was going to sort in a different
order (giving it a parameter to control the sort order) that is
more suitable while repacking, but it seems that the patch is
not needed.
prev parent reply other threads:[~2007-03-11 3:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-11 2:29 [PATCH] prepare_packed_git(): sort packs by age and localness Junio C Hamano
2007-03-11 2:34 ` Shawn O. Pearce
2007-03-11 3:07 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vps7gxyu6.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).