Re: [PATCH] Lose perl dependency. (fwd)

[Junio C Hamano <junkio@cox.net>]

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> Hi,
>
> On Thu, 18 Jan 2007, Simon 'corecode' Schubert wrote:
>
>> Johannes Schindelin wrote:
>> > On Thu, 18 Jan 2007, Simon 'corecode' Schubert wrote:
>> > 
>> > >  for cmt in `git-rev-list --no-merges "$upstream"..ORIG_HEAD \
>> > > -			| @@PERL@@ -e 'print reverse <>'`
>> > > +			| sed -ne '1!G;$p;h'`
>> > 
>> > Why not teach the revision machinery to output in reverse with "--reverse"?
>> 
>> I'm more in favour of "small is beautiful".  Also from looking at the code,
>> this seems to be a bit complicated.
>
> I'm more in favour of "less shell dependecy is beautiful". And from what I 
> can tell, it should be relatively easy:
>
> ---
>
> 	14 insertions and 11 deletions stem from moving (and extern'ing) 
> 	reverse_commit_list() from merge-recursive.c to commit.c
>
> 	So the change is actually 9 insertions and one deletion.

I think this is sane but I hate to having to worry about
possible fallouts from giving --reverse in setup_revisions() to
make it available to everybody.  E.g. things like "what happens
when you say "git format-patch --reverse HEAD~3".

Nevertheless, moving reverse_commit_list out of merge-recursive
is a good clean-up.