Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: ltuikov@yahoo.com
Cc: git@vger.kernel.org, Linus Torvalds <torvalds@osdl.org>
Subject: Re: git-merge-recursive segmentation error
Date: Tue, 19 Dec 2006 18:30:30 -0800	[thread overview]
Message-ID: <7vpsafmh89.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <7vtzzrmhhd.fsf@assigned-by-dhcp.cox.net> (Junio C. Hamano's message of "Tue, 19 Dec 2006 18:25:02 -0800")

Junio C Hamano <junkio@cox.net> writes:

> Luben Tuikov <ltuikov@yahoo.com> writes:
>
>> I also ran git-bisect twice over two well known but overlapping
>> good-bad regions and I get the same commit as being the culprit.
>> It seems to be commit 1510fea781cb0517eeba8c378964f7bc4f9577ab.
>>
>>     Luben
>
> Ooooooops.

1510fe is buggy and it is my fault.

For now, this _should_ get you keep going.

However, if this fixes it for you, that means we would still
have the problem on Cygwin X-<.

-- >8 --
[PATCH] fix populate-filespec

I hand munged the original patch when committing 1510fea78.

Signed-off-by: Junio C Hamano <junkio@cox.net>
---
 diff.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/diff.c b/diff.c
index 9974435..6e6f2a7 100644
--- a/diff.c
+++ b/diff.c
@@ -1223,7 +1223,7 @@ static int reuse_worktree_file(const char *name, const unsigned char *sha1, int
 	 * objects however would tend to be slower as they need
 	 * to be individually opened and inflated.
 	 */
-	if (FAST_WORKING_DIRECTORY && !want_file && has_sha1_pack(sha1, NULL))
+	if (!FAST_WORKING_DIRECTORY && !want_file && has_sha1_pack(sha1, NULL))
 		return 0;
 
 	len = strlen(name);
-- 
1.4.4.2.g205bf


  reply	other threads:[~2006-12-20  2:30 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-20  1:00 git-merge-recursive segmentation error Luben Tuikov
2006-12-20  1:10 ` Linus Torvalds
2006-12-20  2:15   ` Luben Tuikov
2006-12-20  2:25     ` Junio C Hamano
2006-12-20  2:30       ` Junio C Hamano [this message]
2006-12-20  2:33         ` Johannes Schindelin
2006-12-20  2:38         ` Luben Tuikov
2006-12-20  2:43           ` Shawn Pearce
2006-12-20  3:45             ` Junio C Hamano
2006-12-20  2:32     ` Shawn Pearce
2006-12-20  2:39       ` Luben Tuikov
2006-12-20  1:18 ` Johannes Schindelin
2006-12-20  2:18   ` Luben Tuikov
2006-12-20  2:31     ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vpsafmh89.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=git@vger.kernel.org \
    --cc=ltuikov@yahoo.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox