git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: Nicolas Pitre <nico@cam.org>
Cc: git@vger.kernel.org, "J. Bruce Fields" <bfields@fieldses.org>
Subject: Re: [PATCH] Documentation/git-commit: rewrite to make it more end-user friendly.
Date: Sat, 09 Dec 2006 13:59:14 -0800	[thread overview]
Message-ID: <7vpsas91e5.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0612091517010.2630@xanadu.home> (Nicolas Pitre's message of "Sat, 09 Dec 2006 16:15:42 -0500 (EST)")

Nicolas Pitre <nico@cam.org> writes:

>> +Note that the contents of the paths that resolved cleanly by a
>> +conflicted merge are automatically staged for the next commit;
>> +you still need to explicitly identify what you want in the
>> +resulting commit using one of the above methods before
>> +recording the merge commit.
>
> Like I said in another mail,...IMHO the merge 
> example included further down should be sufficient information wrt 
> committing a merge.

You are right --- removed.

>>  -o|--only::
>> -	Commit only the files specified on the command line.
>> -	This format cannot be used during a merge, nor when the
>> -	index and the latest commit does not match on the
>> -	specified paths to avoid confusion.
>> +	Commit only the files specified on the command line;
>> +	this is the default when pathnames are given on the
>> +	command line, so you usually do not have to give this
>> +	option.  This format cannot be used during a merge.
>
> Is there some value in keeping this option documented?  What about 
> removing it (the documentation not the option)?

True, although the description of <files>... need to be
clarified if we do this.

>> +When recording your own work, the contents of modified files in
>> +your working tree are temporarily stored to a staging area
>> +called the "index" with gitlink:git-add[1].  Removal
>
> I like the way the index is introduced at this point.

Credit owed to JBF.

> I'd add (with links):
>
> SEE ALSO
> --------
> git-add, git-rm, git-mv, git-merge, git-commit-tree

Done.

Attached is an incremental patch on top of what you commented
on.

-- >8 --

diff --git a/Documentation/git-commit.txt b/Documentation/git-commit.txt
index 8fe42cb..20a2cb3 100644
--- a/Documentation/git-commit.txt
+++ b/Documentation/git-commit.txt
@@ -34,12 +34,6 @@ methods:
    changes from all known files i.e. files that have already been committed
    before, and perform the actual commit.
 
-Note that the contents of the paths that resolved cleanly by a
-conflicted merge are automatically staged for the next commit;
-you still need to explicitly identify what you want in the
-resulting commit using one of the above methods before
-recording the merge commit.
-
 The gitlink:git-status[1] command can be used to obtain a
 summary of what is included by any of the above for the next
 commit by giving the same set of parameters you would give to
@@ -119,19 +113,15 @@ but can be used to amend a merge commit.
 	as well.  This is usually not what you want unless you
 	are concluding a conflicted merge.
 
--o|--only::
-	Commit only the files specified on the command line;
-	this is the default when pathnames are given on the
-	command line, so you usually do not have to give this
-	option.  This format cannot be used during a merge.
-
 \--::
 	Do not interpret any more arguments as options.
 
 <file>...::
-	Files to be committed.  The meaning of these is
-	different between `--include` and `--only`.  Without
-	either, it defaults `--only` semantics.
+	When files are given on the command line, the command
+	commits the contents of the named files, without
+	recording the changes already staged.  The contents of
+	these files are also staged for the next commit on top
+	of what have been staged before.
 
 
 EXAMPLES
@@ -240,6 +230,15 @@ This command can run `commit-msg`, `pre-commit`, and
 `post-commit` hooks.  See link:hooks.html[hooks] for more
 information.
 
+
+SEE ALSO
+--------
+gitlink:git-add[1],
+gitlink:git-rm[1],
+gitlink:git-mv[1],
+gitlink:git-merge[1],
+gitlink:git-commit-tree[1]
+
 Author
 ------
 Written by Linus Torvalds <torvalds@osdl.org> and

  reply	other threads:[~2006-12-09 21:59 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-08 11:20 Documentation/git-commit.txt Junio C Hamano
2006-12-08 11:55 ` Documentation/git-commit.txt Salikh Zakirov
2006-12-08 19:31   ` Documentation/git-commit.txt Junio C Hamano
2006-12-08 19:45     ` Documentation/git-commit.txt Nicolas Pitre
2006-12-08 22:56   ` Documentation/git-commit.txt Alan Chandler
2006-12-10  0:11     ` Documentation/git-commit.txt Horst H. von Brand
2006-12-10  9:23       ` Documentation/git-commit.txt Alan Chandler
2006-12-11 14:58         ` Documentation/git-commit.txt Andreas Ericsson
2006-12-09  2:58 ` Documentation/git-commit.txt Nicolas Pitre
2006-12-09  4:25   ` Documentation/git-commit.txt Junio C Hamano
2006-12-09  4:42     ` Documentation/git-commit.txt J. Bruce Fields
2006-12-09 19:58     ` Documentation/git-commit.txt Nicolas Pitre
2006-12-09 20:49       ` Documentation/git-commit.txt Jakub Narebski
2006-12-09  5:48   ` [PATCH] Documentation/git-commit: rewrite to make it more end-user friendly Junio C Hamano
2006-12-09 21:15     ` Nicolas Pitre
2006-12-09 21:59       ` Junio C Hamano [this message]
2006-12-09 22:05         ` Jakub Narebski
2006-12-09 22:19           ` Linus Torvalds
2006-12-09 22:24             ` Jakub Narebski
2006-12-09 22:26         ` Nicolas Pitre
2006-12-10  0:30     ` Josef Weidendorfer
2006-12-10  0:51       ` Nicolas Pitre
2006-12-10 21:00       ` J. Bruce Fields
2006-12-10 22:07         ` Nicolas Pitre
2006-12-10 22:41           ` J. Bruce Fields
2006-12-10 23:05           ` Junio C Hamano
2006-12-10  9:17     ` Alan Chandler
2006-12-09  4:31 ` Documentation/git-commit.txt J. Bruce Fields

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vpsas91e5.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=bfields@fieldses.org \
    --cc=git@vger.kernel.org \
    --cc=nico@cam.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).