git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: ltuikov@yahoo.com
Cc: git@vger.kernel.org
Subject: Re: [PATCH] gitweb: make leftmost column of blame less cluttered.
Date: Mon, 02 Oct 2006 21:19:57 -0700	[thread overview]
Message-ID: <7vpsdat4ia.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20061002192930.86293.qmail@web31803.mail.mud.yahoo.com> (Luben Tuikov's message of "Mon, 2 Oct 2006 12:29:30 -0700 (PDT)")

Luben Tuikov <ltuikov@yahoo.com> writes:

> --- Junio C Hamano <junkio@cox.net> wrote:
>
>> Instead of labelling each and every line with clickable commit
>> object name, this makes the blame output to show them only on
>> the first line of each group of lines from the same revision.
>> 
>> Also it makes mouse-over to show the minimum authorship and
>> authordate information for extra cuteness ;-).
>> 
>> Signed-off-by: Junio C Hamano <junkio@cox.net>
>> ---
>
> ACK.  Please commit.

Won't, at least as its current shape.  Somebody privately
mentioned that the code risks slurping the entire file in the
@chunk if it is untouched since the initial import, which is not
what we want.

The memory consumption worries aside, that would make the
clickable commit object name to appear only very at the
beginning of the page and would make it inconvenient to actually
visit the commit after scrolling down to see later lines.

It might become usable if it is given a cap to limit the number
of lines to put in a chunk.  I dunno.

  reply	other threads:[~2006-10-03  4:20 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-01  9:19 [PATCH] gitweb: make leftmost column of blame less cluttered Junio C Hamano
2006-10-02 19:29 ` Luben Tuikov
2006-10-03  4:19   ` Junio C Hamano [this message]
2006-10-03  7:25     ` Junio C Hamano
2006-10-03 19:08       ` Luben Tuikov
2006-10-03 19:20       ` Martin Waitz
2006-10-03 19:45         ` Luben Tuikov
2006-10-04  2:26           ` Junio C Hamano
2006-10-04  2:48             ` Luben Tuikov
2006-10-04  3:07               ` Jakub Narebski
2006-10-04  8:12               ` Junio C Hamano
2006-10-04 15:59                 ` Luben Tuikov
2006-10-05  1:03                   ` Junio C Hamano
2006-10-05  1:11                     ` Luben Tuikov
2006-10-03 19:01     ` Luben Tuikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vpsdat4ia.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=git@vger.kernel.org \
    --cc=ltuikov@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).