Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: git@vger.kernel.org
Cc: Jon Loeliger <jdl@freescale.com>
Subject: Re: [PATCH 4/4] upload-pack/fetch-pack: support side-band communication
Date: Wed, 21 Jun 2006 17:17:38 -0700	[thread overview]
Message-ID: <7vpsh2xcv1.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <7vsllyzs9w.fsf@assigned-by-dhcp.cox.net> (Junio C. Hamano's message of "Wed, 21 Jun 2006 04:01:47 -0700")

Junio C Hamano <junkio@cox.net> writes:

> This implements a protocol extension between fetch-pack and
> upload-pack to allow stderr stream from upload-pack (primarily
> used for the progress bar display) to be passed back.
>
> Signed-off-by: Junio C Hamano <junkio@cox.net>
> ---
>
>  * With this, fetching and cloning over git+ssh:// and git://
>    does not discard the progress bar and error messages that
>    upload-pack emits on its standard output.  They are sent to
>    the downloader and shown to the user.
>
>    Somehow this does not work when connecting to git daemon that
>    runs under inetd.  Fixes appreciated.

This seems to fix it.

-- >8 --
Subject: [PATCH] daemon: send stderr to /dev/null instead of closing.

Signed-off-by: Junio C Hamano <junkio@cox.net>
---
 daemon.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/daemon.c b/daemon.c
index bdfe80d..0747ce2 100644
--- a/daemon.c
+++ b/daemon.c
@@ -757,7 +757,7 @@ int main(int argc, char **argv)
 		struct sockaddr *peer = (struct sockaddr *)&ss;
 		socklen_t slen = sizeof(ss);
 
-		fclose(stderr); //FIXME: workaround
+		freopen("/dev/null", "w", stderr);
 
 		if (getpeername(0, peer, &slen))
 			peer = NULL;
-- 
1.4.0.g7883

  reply	other threads:[~2006-06-22  0:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-21 11:01 [PATCH 4/4] upload-pack/fetch-pack: support side-band communication Junio C Hamano
2006-06-22  0:17 ` Junio C Hamano [this message]
2006-06-22 16:22   ` Jon Loeliger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vpsh2xcv1.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=git@vger.kernel.org \
    --cc=jdl@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox