From: Junio C Hamano <junkio@cox.net>
To: Linus Torvalds <torvalds@osdl.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/2] Add builtin "git rm" command
Date: Sun, 21 May 2006 01:20:08 -0700 [thread overview]
Message-ID: <7vpsi7zt53.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0605191607580.10823@g5.osdl.org> (Linus Torvalds's message of "Fri, 19 May 2006 16:19:34 -0700 (PDT)")
Linus Torvalds <torvalds@osdl.org> writes:
> I think the new behaviour is strictly an improvement, but perhaps more
> importantly, it is _different_. As a special case, the semantics are
> identical for the single-file case (which is the only one our test-suite
> seems to test).
>
> The other question is what to do with leading directories. The old "git
> rm" script didn't do anything, which is somewhat inconsistent. This one
> will actually clean up directories that have become empty as a result of
> removing the last file, but maybe we want to have a flag to decide the
> behaviour?
I too think these are improvements. Thanks for the patch.
BTW, this needed another "evil merge" into "next", so this time
I made a separate evil merge branch that I speculated as a
possibly better alternative approach in an earlier message.
prev parent reply other threads:[~2006-05-21 8:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-19 23:07 [PATCH 1/2] Move pathspec matching from builtin-add.c into dir.c Linus Torvalds
2006-05-19 23:19 ` [PATCH 2/2] Add builtin "git rm" command Linus Torvalds
2006-05-21 8:20 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vpsi7zt53.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox