From: Junio C Hamano <junkio@cox.net>
To: iler.ml@gmail.com
Cc: git@vger.kernel.org
Subject: Re: (patch) calloc->xaclloc in read-cache.c
Date: Tue, 09 May 2006 06:26:59 -0700 [thread overview]
Message-ID: <7vpsin5nx8.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <0IZ000KI11YCKL10@mxout4.netvision.net.il> (iler ml's message of "Tue, 09 May 2006 16:14 +0000")
iler.ml@gmail.com writes:
> How about this.
Looks good, thanks. If you needed some MUA trick that other
people might benefit from please feel free to send a patch to
Documentation/SubmittingPatches "MUA specific hints" section.
Except "Subject: [PATCH] blah", commit log message (in this case
what you would have on the Subject line is to the point and you
would not need any extra log message), "Signed-off-by: whom",
and perhaps "---\n". Material that you do not want to have in
the final commit message, like "How about this" and diffstat if
you have one, would come after the "---\n" line.
Your message formatted in the preferred way becomes like this:
Subject: [PATCH] read-cache.c: use xcalloc() not calloc()
Elsewhere we use xcalloc(); we should consistently do so.
Signed-off-by: Yakov Lerner <iler.ml@gmail.com>
---
* How about this?
read-cache.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
--- read-cache.c.000 2006-05-09 15:27:56.000000000 +0000
+++ read-cache.c 2006-05-09 15:28:10.000000000 +0000
@@ -552,7 +552,7 @@
active_nr = ntohl(hdr->hdr_entries);
...
prev parent reply other threads:[~2006-05-09 13:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-09 16:14 (patch) calloc->xaclloc in read-cache.c iler.ml
2006-05-09 13:26 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vpsin5nx8.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=iler.ml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).