From: Junio C Hamano <junkio@cox.net>
To: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Cc: Petr Baudis <pasky@suse.cz>, git@vger.kernel.org
Subject: Re: [PATCH] Fix unconditional early exit in cg-fetch
Date: Mon, 19 Dec 2005 17:15:19 -0800 [thread overview]
Message-ID: <7vpsnso9g8.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20051219161736.18245.98591.stgit@zion.home.lan> (Paolo Giarrusso's message of "Mon, 19 Dec 2005 17:17:36 +0100")
Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it> writes:
> if [ "$get" = "get_rsync" ]; then
> $get -i -s -u -d "$uri/refs/tags" "$_git/refs/tags" ||
> - echo "unable to get tags list (non-fatal)" >&2
> - exit $?
> + (echo "unable to get tags list (non-fatal)" >&2;
> + exit $?)
> fi
Why would you want a subshell that exits with a non-zero status
when nobody is checking that status anyway?
I suspect removing "exit $?" would suffice, if that condition is
non-fatal as the message says...
next prev parent reply other threads:[~2005-12-20 1:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-19 16:17 [PATCH] Fix unconditional early exit in cg-fetch Paolo 'Blaisorblade' Giarrusso
2005-12-20 1:15 ` Junio C Hamano [this message]
2005-12-20 15:25 ` Blaisorblade
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vpsnso9g8.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=blaisorblade@yahoo.it \
--cc=git@vger.kernel.org \
--cc=pasky@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).