From: Junio C Hamano <junkio@cox.net>
To: Paul Mackerras <paulus@samba.org>
Cc: git@vger.kernel.org
Subject: Re: gitk "hyperlinks"
Date: Sat, 06 Aug 2005 09:31:38 -0700 [thread overview]
Message-ID: <7vpssr9gd1.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <17140.47152.672091.474748@cargo.ozlabs.ibm.com> (Paul Mackerras's message of "Sat, 6 Aug 2005 23:16:32 +1000")
Paul Mackerras <paulus@samba.org> writes:
> Good idea. Also done. :) It's on master.kernel.org now in my gitk.git
> directory. Hopefully Junio will pull it into git soon.
I did, and will push it out shortly, but I think you need this
patch. To make later merges from you easier, I will not put
this in my "master" branch.
------------
[PATCH] gitk proposed fix: handle more than one SHA1 links.
Signed-off-by: Junio C Hamano <junkio@cox.net>
---
gitk | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
c423b62a66d4c4f2a7856cada507f973e9140590
diff --git a/gitk b/gitk
--- a/gitk
+++ b/gitk
@@ -1802,6 +1802,7 @@ proc selectline {l isnew} {
set linkid [string range $comment $s $e]
if {![info exists idline($linkid)]} continue
incr e
+ incr i
$ctext tag conf link$i -foreground blue -underline 1
$ctext tag add link$i "$commentstart + $s c" "$commentstart + $e c"
$ctext tag bind link$i <1> [list selectline $idline($linkid) 1]
next prev parent reply other threads:[~2005-08-06 16:31 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-30 1:51 Display of merges in gitk Paul Mackerras
2005-07-30 4:25 ` Junio C Hamano
2005-07-30 21:36 ` Shipping gitk as part of core git Junio C Hamano
2005-07-31 12:00 ` Paul Mackerras
2005-07-31 18:48 ` Junio C Hamano
2005-07-30 14:32 ` gitk merge display bugs (was: Re: Display of merges in gitk) Sergey Vlasov
2005-08-05 14:10 ` Display of merges in gitk Linus Torvalds
2005-08-05 14:37 ` gitk "hyperlinks" (was Re: Display of merges in gitk) Linus Torvalds
2005-08-05 18:51 ` jepler
2005-08-06 3:36 ` Kay Sievers
2005-08-06 15:44 ` Linus Torvalds
2005-08-07 5:51 ` Kay Sievers
2005-08-06 18:27 ` gitweb "tag" display Junio C Hamano
2005-08-06 18:49 ` Junio C Hamano
2005-08-19 23:21 ` Paul Mackerras
2005-08-19 23:43 ` Johannes Schindelin
2005-08-20 19:09 ` Junio C Hamano
2005-08-07 5:50 ` Kay Sievers
2005-08-06 13:16 ` gitk "hyperlinks" (was Re: Display of merges in gitk) Paul Mackerras
2005-08-06 16:20 ` Linus Torvalds
2005-08-06 17:07 ` jepler
2005-08-06 17:59 ` gitk SHA link hovers Linus Torvalds
2005-08-07 12:04 ` Paul Mackerras
2005-08-06 16:31 ` Junio C Hamano [this message]
2005-08-07 12:05 ` gitk "hyperlinks" Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vpssr9gd1.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).