Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: Petr Baudis <pasky@ucw.cz>
Cc: torvalds@osdl.org, git@vger.kernel.org
Subject: Re: [PATCH] Make git-update-cache --force-remove regular
Date: Tue, 31 May 2005 12:52:17 -0700	[thread overview]
Message-ID: <7vpsv7xjf2.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20050531165243.GD7013@pasky.ji.cz> (Petr Baudis's message of "Tue, 31 May 2005 18:52:43 +0200")

>>>>> "PB" == Petr Baudis <pasky@ucw.cz> writes:

PB> Make the --force-remove flag behave same as --add, --remove and
PB> --replace. This means I can do

PB> 	git-update-cache --force-remove -- file1.c file2.c

PB> which is probably saner and also makes it easier to use in cg-rm.

I am ambivalent about this.  Although I like the semantic
clean-up your proposed change makes, at the same time: 

  $ git-update-cache --force-remove one --add two

used to remove "one" and add "two", which has to be now written
as two separate calls, which is a slight a performance hit of
having to read the 1.6MB cache twice.  Maybe it does not matter,
or the new usage's convenience outweighs it; I cannot tell
offhand.


  reply	other threads:[~2005-05-31 19:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-31 16:52 [PATCH] Make git-update-cache --force-remove regular Petr Baudis
2005-05-31 19:52 ` Junio C Hamano [this message]
2005-05-31 20:41   ` Petr Baudis
2005-06-05 23:26 ` Petr Baudis
2005-06-05 23:58   ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vpsv7xjf2.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=git@vger.kernel.org \
    --cc=pasky@ucw.cz \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox