From: Junio C Hamano <junkio@cox.net>
To: git@vger.kernel.org
Subject: [RFH] Janitor projects around core GIT
Date: Mon, 16 May 2005 21:48:14 -0700 [thread overview]
Message-ID: <7vpsvqihkh.fsf@assigned-by-dhcp.cox.net> (raw)
Here is a list of things I would like to see done by people who
want to get their hands dirty ;-).
* Rewrite command line parsing code, probably using GNU getopt.
I have three gripes about option parsing in the current code:
- Some pretend to take long options, but allow only --long
without allowing --lon or --lo. Some say "--flag=argument"
while others say "--flag argument", which is inconsistent
and confusing.
- For some commands the order of options matter for no
apparently good reason. The most prominent example is
"checkout-cache -a -f" vs "checkout-cache -f -a"; yes I
know about the comment Linus wrote, but it is more a
warning for people not to get confused by this behaviour;
not a justification for that confusing behaviour.
- Related to the second point, many commands perform actions
as they go parsing and processing the options. It would be
cleaner and easier to add new options later if the option
processing loop is reorganized so that optionss are done
first and after all options are collected, real processing
begins. The current way lets you make "update-cache foo
--add bar" to refuse to add foo but to allow adding bar,
but I do not think being able to do that kind of thing is
buying us much.
* Extend coverage of tests to more commands in the t/ directory.
* const-ness cleanups.
* Use correct types for sizes of things, as HPA suggested the
other day.
* It would be nice if somebody who is handy with checker/sparse
type tools to run them on core GIT part and/or run core GIT
part under purify.
next reply other threads:[~2005-05-17 4:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-17 4:48 Junio C Hamano [this message]
2005-05-17 4:56 ` [RFH] Janitor projects around core GIT Jeff Garzik
2005-05-17 15:49 ` Ed L Cashin
2005-05-17 12:30 ` Name of test directory (was: [RFH] Janitor projects around core GIT) Kevin Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vpsvqihkh.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).