From: Junio C Hamano <gitster@pobox.com>
To: Jens Lehmann <Jens.Lehmann@web.de>
Cc: Heiko Voigt <hvoigt@hvoigt.net>,
Fredrik Gustafsson <iveqy@iveqy.com>,
git@vger.kernel.org
Subject: Re: [PATCH] [submodule] Add depth to submodule update
Date: Fri, 28 Jun 2013 15:51:41 -0700 [thread overview]
Message-ID: <7vr4fllugy.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <51CDF819.9030308@web.de> (Jens Lehmann's message of "Fri, 28 Jun 2013 22:54:49 +0200")
Jens Lehmann <Jens.Lehmann@web.de> writes:
> Am 28.06.2013 20:44, schrieb Junio C Hamano:
>> Heiko Voigt <hvoigt@hvoigt.net> writes:
>> ...
>>> Hmm, but does it have a --depth option for revisions? Maybe we should
>>> call it --clone-depth or --rev-depth to make it clear? --depth and
>>> --max-depth would be completely orthogonal but the name does not allow
>>> to distinguish them properly.
>>
>> I do not have a strong opinion either way, but as you suggest, it
>> might be a good idea to call this new option --clone-depth to be
>> more specific.
>
> No strong opinion here either, but I'm leaning towards "--depth"
> because on one hand we already have the "--reference" option which
> is passed on to the clone command (and not "--clone-reference")...
OK, then "--depth" it is.
The points in your review on the last version with "--depth" (which
I picked up and parked on 'pu') still need to be addressed, I think?
next prev parent reply other threads:[~2013-06-28 22:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-23 8:04 [RFC] [submodule] Add depth to submodule update Fredrik Gustafsson
2013-06-24 22:49 ` [PATCH] " Fredrik Gustafsson
2013-06-25 5:07 ` Junio C Hamano
2013-06-25 22:11 ` Heiko Voigt
2013-06-26 16:02 ` Fredrik Gustafsson
2013-06-26 21:03 ` Junio C Hamano
2013-06-27 14:54 ` Jens Lehmann
2013-06-28 6:50 ` Heiko Voigt
2013-06-28 18:44 ` Junio C Hamano
2013-06-28 20:54 ` Jens Lehmann
2013-06-28 22:51 ` Junio C Hamano [this message]
2013-06-28 23:07 ` Fredrik Gustafsson
2013-06-30 19:17 ` Junio C Hamano
2013-06-26 16:16 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vr4fllugy.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Jens.Lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=hvoigt@hvoigt.net \
--cc=iveqy@iveqy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).