git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH 4/4] t4300 (rebase): don't unnecessarily set GIT_TRACE
Date: Fri, 10 May 2013 08:42:16 -0700	[thread overview]
Message-ID: <7vr4he3kpz.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <CALkWK0k_ArM9EpY0S7=mbgFpHsoauZCr9e=ESX_CEA5-vRHrHQ@mail.gmail.com> (Ramkumar Ramachandra's message of "Fri, 10 May 2013 20:16:42 +0530")

Ramkumar Ramachandra <artagnon@gmail.com> writes:

> Junio C Hamano wrote:
>> Ramkumar Ramachandra <artagnon@gmail.com> writes:
>>
>>> A couple of tests execute 'git rebase' with GIT_TRACE set to 1, but
>>> this trace output is not used anywhere.
>>
>> Isn't it shown in "t4300-*.sh -v" output to help the debugger?
>
> Um, but why the GIT_TRACE in just these two places?  Can't I set
> GIT_TRACE=1 when executing the shell script if I really wanted that?

Perhaps because this is a test about "rebase" and a typical debugger
does not want to trace other "git" things while debugging this?

  reply	other threads:[~2013-05-10 15:42 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-10 14:29 [PATCH 0/4] Trivial cleanups to t3400 (rebase) Ramkumar Ramachandra
2013-05-10 14:29 ` [PATCH 1/4] t3400 (rebase): don't set GIT_AUTHOR_{NAME,EMAIL} Ramkumar Ramachandra
2013-05-10 14:53   ` Eric Sunshine
2013-05-10 14:56     ` Ramkumar Ramachandra
2013-05-10 17:34     ` Junio C Hamano
2013-05-10 14:29 ` [PATCH 2/4] t3400 (rebase): downcase a couple of test titles Ramkumar Ramachandra
2013-05-10 14:29 ` [PATCH 3/4] t3400 (rebase): move lone statement into a test Ramkumar Ramachandra
2013-05-10 14:29 ` [PATCH 4/4] t4300 (rebase): don't unnecessarily set GIT_TRACE Ramkumar Ramachandra
2013-05-10 14:38   ` Junio C Hamano
2013-05-10 14:46     ` Ramkumar Ramachandra
2013-05-10 15:42       ` Junio C Hamano [this message]
2013-05-10 16:42         ` Ramkumar Ramachandra
2013-05-10 17:51           ` Junio C Hamano
2013-05-10 18:06             ` Ramkumar Ramachandra
2013-05-10 18:08               ` Ramkumar Ramachandra
2013-05-10 19:07               ` Jonathan Nieder
2013-05-10 19:14                 ` Ramkumar Ramachandra
2013-05-10 19:16                   ` Jonathan Nieder
2013-05-10 21:06                     ` Junio C Hamano
2013-05-11 11:37                       ` Ramkumar Ramachandra
2013-05-13 23:05                         ` Jonathan Nieder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vr4he3kpz.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=artagnon@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).