From: Junio C Hamano <gitster@pobox.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org, Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>,
Thomas Rast <trast@student.ethz.ch>,
Stephen Boyd <bebarino@gmail.com>
Subject: Re: [PATCH v2 1/2] send-email: make annotate configurable
Date: Sat, 06 Apr 2013 20:32:17 -0700 [thread overview]
Message-ID: <7vr4in818e.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: 1365239012-15079-2-git-send-email-felipe.contreras@gmail.com
Felipe Contreras <felipe.contreras@gmail.com> writes:
> @@ -305,6 +306,7 @@ my $rc = GetOptions("h" => \$help,
> "smtp-domain:s" => \$smtp_domain,
> "identity=s" => \$identity,
> "annotate" => \$annotate,
> + "no-annotate" => \$no_annotate,
Wouldn't it be much better to let GetOptions know that --no-annotate
is allowed by saying
"annotate!" => \$annotate
which also let us lose an extra $no_annotate variable?
next prev parent reply other threads:[~2013-04-07 3:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-06 9:03 [PATCH v2 0/2] send-email: couple of improvements Felipe Contreras
2013-04-06 9:03 ` [PATCH v2 1/2] send-email: make annotate configurable Felipe Contreras
2013-04-07 3:32 ` Junio C Hamano [this message]
2013-04-07 6:54 ` Felipe Contreras
2013-04-06 9:03 ` [PATCH v2 2/2] format-patch: add format.cover-letter configuration Felipe Contreras
2013-04-06 12:43 ` Ramkumar Ramachandra
2013-04-06 16:02 ` Felipe Contreras
2013-04-06 17:43 ` Matthieu Moy
2013-04-06 17:43 ` Matthieu Moy
2013-04-07 3:32 ` Junio C Hamano
2013-04-07 5:46 ` Felipe Contreras
2013-04-06 17:47 ` [PATCH v2 0/2] send-email: couple of improvements Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vr4in818e.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=bebarino@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).