git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Miklos Vajna <vmiklos@suse.cz>
Cc: Brandon Casey <drafnel@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] cherry-pick -x: improve handling of one-liner commit messages
Date: Fri, 29 Mar 2013 13:49:29 -0700	[thread overview]
Message-ID: <7vr4iylyna.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20130329203915.GA5157@suse.cz> (Miklos Vajna's message of "Fri, 29 Mar 2013 21:39:16 +0100")

Miklos Vajna <vmiklos@suse.cz> writes:

> On Fri, Mar 29, 2013 at 10:41:17AM -0700, Brandon Casey <drafnel@gmail.com> wrote:
>
>> > I think this is part of the bc/append-signed-off-by topic that is
>> > about to graduate to 'master'; more specifically, b971e04f54e7
>> > (sequencer.c: always separate "(cherry picked from" from commit
>> > body, 2013-02-12) does the equivalent, no?
>> 
>> Yeah, I think this case is already handled.
>> 
>> Miklos, can you check out next and see if your problem case is handled?
>
> I just checked next and right, that solves the problem I was fixing.
>
> So -- sorry for the noise. :-)

Don't be sorry.

People noticing an issue, trying 'master' and 'next' to see that it
has already been resolved, is the only way for us to know we are
helping people other than those who had the original itch.

The ideal would be for more people to run 'next' and report both
problems and successes ;-)

      reply	other threads:[~2013-03-29 20:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-29 15:38 [PATCH] cherry-pick -x: improve handling of one-liner commit messages Miklos Vajna
2013-03-29 17:23 ` Junio C Hamano
2013-03-29 17:41   ` Brandon Casey
2013-03-29 20:39     ` Miklos Vajna
2013-03-29 20:49       ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vr4iylyna.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=drafnel@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=vmiklos@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).