git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Brandon Casey <drafnel@gmail.com>
Cc: Andreas Schwab <schwab@linux-m68k.org>,
	felipe.contreras@gmail.com, git@vger.kernel.org
Subject: Re: [PATCH] git-completion.bash: replace zsh notation that breaks bash 3.X
Date: Fri, 18 Jan 2013 11:08:27 -0800	[thread overview]
Message-ID: <7vr4liqpg4.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <CA+sFfMd6FLchoOcUpNZ3AxTLNp3qe=VjijRid4sWf-A3_w88qw@mail.gmail.com> (Brandon Casey's message of "Fri, 18 Jan 2013 11:07:14 -0800")

Brandon Casey <drafnel@gmail.com> writes:

> On Fri, Jan 18, 2013 at 7:02 AM, Andreas Schwab <schwab@linux-m68k.org> wrote:
>> Brandon Casey <drafnel@gmail.com> writes:
>>
>>> +                             array[$(($#array+1))]="$c"
>>
>> You don't need $(( )) since the array index is already evaluated as an
>> arithmethic expression.
>
> Ah, I didn't know that.  Thanks.
>
> I think Junio will probably fix this up if he thinks it's worth it,
> but I can resubmit if necessary.

Please; I do not have mental bandwidth to keep track of contrib/
material myself.

  reply	other threads:[~2013-01-18 19:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-18 10:31 [PATCH] git-completion.bash: replace zsh notation that breaks bash 3.X Brandon Casey
2013-01-18 15:02 ` Andreas Schwab
2013-01-18 19:07   ` Brandon Casey
2013-01-18 19:08     ` Junio C Hamano [this message]
2013-01-18 19:11       ` Brandon Casey
2013-01-18 19:24         ` [PATCH v2] " Brandon Casey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vr4liqpg4.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=drafnel@gmail.com \
    --cc=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).