From: Junio C Hamano <gitster@pobox.com>
To: Phillip Susi <psusi@ubuntu.com>
Cc: git@vger.kernel.org
Subject: Re: Enabling scissors by default?
Date: Tue, 08 Jan 2013 15:36:09 -0800 [thread overview]
Message-ID: <7vr4lvb63a.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <50ECAAE2.2020507@ubuntu.com> (Phillip Susi's message of "Tue, 08 Jan 2013 18:25:22 -0500")
Phillip Susi <psusi@ubuntu.com> writes:
> On 01/08/2013 05:42 PM, Junio C Hamano wrote:
>> It is very easy to miss misidentification of scissors line; as a
>> dangerous, potentially information losing option, I do not think
>> it should be on by default.
>
> I suppose if it only requires one instance of >8 or <8 and one -, it
> might be *slightly* dangerous, but if it required a slightly longer
> minimum line length, it would be pretty darn unlikely to get triggered
> by accident, and of course, is easily disabled.
"Easily disabled" is never a good enough reason to change the long
established default of not doing anything funky unless the user
explicitly asks it to do things differently.
You could introduce a new configuration variable "am.scissors" and
personally turn it on, though. Setting that variable *does* count
as the user explicitly asking for it.
> I often see patches being tweaked in response to feedback and
> resubmitted, usually with a description of what has changed since the
> previous version. Such descriptions don't need to be in the change
> log when it is finally applied and seem a perfect use of scissors.
Putting such small logs under "---" line is the accepted practice.
next prev parent reply other threads:[~2013-01-08 23:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-08 21:42 Enabling scissors by default? Phillip Susi
2013-01-08 22:42 ` Junio C Hamano
2013-01-08 23:25 ` Phillip Susi
2013-01-08 23:36 ` Junio C Hamano [this message]
2013-01-09 17:10 ` Jeff King
2013-01-09 17:40 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vr4lvb63a.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=psusi@ubuntu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).