git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: esr@thyrsus.com
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [PATCH] Python scripts audited for minimum compatible version and checks added.
Date: Sun, 23 Dec 2012 20:57:12 -0800	[thread overview]
Message-ID: <7vr4mgnj2v.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <7vk3sc2hx9.fsf@alter.siamese.dyndns.org> (Junio C. Hamano's message of "Thu, 20 Dec 2012 19:38:42 -0800")

Junio C Hamano <gitster@pobox.com> writes:

> I needed something like this on top of it to get it pass t5800.
>
> diff --git a/git_remote_helpers/git/__init__.py b/git_remote_helpers/git/__init__.py
> index 776e891..5047fd4 100644
> --- a/git_remote_helpers/git/__init__.py
> +++ b/git_remote_helpers/git/__init__.py
> @@ -1,3 +1,5 @@
> +import sys
> +
>  if sys.hexversion < 0x02040000:
>      # The limiter is the subprocess module
>      sys.stderr.write("git_remote_helpers: requires Python 2.4 or later.")

Ping?  Is the above the best fix for the breakage?

If it weren't __init__, I'd silently squash it in, but the filename
feels a bit more magic than the ordinary *.py files, so I was worried
there may be some other rules involved what can and cannot go in to
such a file, hence I've been waiting for an ack or alternatives.

Thanks.

  reply	other threads:[~2012-12-24  4:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-20 14:13 [PATCH] Python scripts audited for minimum compatible version and checks added Eric S. Raymond
2012-12-20 14:48 ` Jeff King
2012-12-20 15:02   ` Eric S. Raymond
2012-12-20 18:25     ` Junio C Hamano
2012-12-21  3:38       ` Junio C Hamano
2012-12-24  4:57         ` Junio C Hamano [this message]
2012-12-24  5:21           ` Eric S. Raymond
2012-12-21 15:58 ` Manlio Perillo
2012-12-24 13:36 ` Pete Wyckoff
2012-12-24 15:32   ` Eric S. Raymond
2012-12-24 19:12     ` Junio C Hamano
2012-12-24 19:52       ` Eric S. Raymond

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vr4mgnj2v.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=esr@thyrsus.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).