From: Junio C Hamano <gitster@pobox.com>
To: Pete Wyckoff <pw@padd.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 00/21] git p4: work on cygwin
Date: Fri, 28 Sep 2012 12:17:40 -0700 [thread overview]
Message-ID: <7vr4pmkld7.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1348833865-6093-1-git-send-email-pw@padd.com> (Pete Wyckoff's message of "Fri, 28 Sep 2012 08:04:04 -0400")
Pete Wyckoff <pw@padd.com> writes:
> This series fixes problems in git-p4, and its tests, so that
> git-p4 works on the cygwin platform.
>
> See the wiki for info on how to get started on cygwin:
>
> https://git.wiki.kernel.org/index.php/GitP4
>
> Testing by people who use cygwin would be appreciated. It would
> be good to support cygwin more regularly. Anyone who had time
> to contribute to testing on cygwin, and reporting problems, would
> be welcome.
>
> There's more work requried to support msysgit. Those patches
> are not in good enough shape to ship out yet, but a lot of what
> is in this series is required for msysgit too.
>
> These patches:
>
> - fix bugs in git-p4 related to issues found on cygwin
> - cleanup some ugly code in git-p4 observed in error paths while
> getting tests to work on cygwin
> - simplify and refactor code and tests to make cygwin changes easier
> - handle newline and path issues for cygwin platform
> - speed up some aspects of git-p4 by removing extra shell invocations
>
> Pete Wyckoff (21):
> git p4: temp branch name should use / even on windows
> git p4: remove unused imports
> git p4: generate better error message for bad depot path
> git p4: fix error message when "describe -s" fails
> git p4 test: use client_view to build the initial client
> git p4 test: use client_view in t9806
> git p4 test: start p4d inside its db dir
> git p4 test: translate windows paths for cygwin
> git p4: remove unreachable windows \r\n conversion code
> git p4: scrub crlf for utf16 files on windows
> git p4 test: newline handling
> git p4 test: use LineEnd unix in windows tests too
> git p4 test: avoid wildcard * in windows
> git p4: cygwin p4 client does not mark read-only
> git p4 test: disable chmod test for cygwin
> git p4: disable read-only attribute before deleting
> git p4: avoid shell when mapping users
> git p4: avoid shell when invoking git rev-list
> git p4: avoid shell when invoking git config --get-all
> git p4: avoid shell when calling git config
> git p4: introduce gitConfigBool
Very nicely done. I was impressed how easy to understand what the
problem each patch attempts to solve is and how it should be solved
only from the description and the changes apparently matched the
description.
I wish patches from everybody looked like these.
prev parent reply other threads:[~2012-09-28 19:18 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-28 12:04 [PATCH 00/21] git p4: work on cygwin Pete Wyckoff
2012-09-28 12:04 ` [PATCH 01/21] git p4: temp branch name should use / even on windows Pete Wyckoff
2012-09-28 12:04 ` [PATCH 02/21] git p4: remove unused imports Pete Wyckoff
2012-09-28 12:04 ` [PATCH 03/21] git p4: generate better error message for bad depot path Pete Wyckoff
2012-09-28 18:58 ` Junio C Hamano
2012-09-28 12:04 ` [PATCH 04/21] git p4: fix error message when "describe -s" fails Pete Wyckoff
2012-09-28 19:02 ` Junio C Hamano
2012-09-28 12:04 ` [PATCH 05/21] git p4 test: use client_view to build the initial client Pete Wyckoff
2012-09-28 19:06 ` Junio C Hamano
2012-09-28 12:04 ` [PATCH 06/21] git p4 test: use client_view in t9806 Pete Wyckoff
2012-09-28 19:11 ` Junio C Hamano
2013-01-27 1:51 ` Pete Wyckoff
2012-09-28 12:04 ` [PATCH 07/21] git p4 test: start p4d inside its db dir Pete Wyckoff
2012-09-28 12:04 ` [PATCH 08/21] git p4 test: translate windows paths for cygwin Pete Wyckoff
2012-09-28 12:04 ` [PATCH 09/21] git p4: remove unreachable windows \r\n conversion code Pete Wyckoff
2012-09-28 12:04 ` [PATCH 10/21] git p4: scrub crlf for utf16 files on windows Pete Wyckoff
2012-09-28 12:04 ` [PATCH 11/21] git p4 test: newline handling Pete Wyckoff
2012-09-28 12:04 ` [PATCH 12/21] git p4 test: use LineEnd unix in windows tests too Pete Wyckoff
2012-09-28 12:04 ` [PATCH 13/21] git p4 test: avoid wildcard * in windows Pete Wyckoff
2012-09-28 12:04 ` [PATCH 14/21] git p4: cygwin p4 client does not mark read-only Pete Wyckoff
2012-09-28 12:04 ` [PATCH 15/21] git p4 test: disable chmod test for cygwin Pete Wyckoff
2012-09-28 19:33 ` Johannes Sixt
2012-09-28 12:04 ` [PATCH 16/21] git p4: disable read-only attribute before deleting Pete Wyckoff
2012-09-28 12:04 ` [PATCH 17/21] git p4: avoid shell when mapping users Pete Wyckoff
2012-09-28 12:04 ` [PATCH 18/21] git p4: avoid shell when invoking git rev-list Pete Wyckoff
2012-09-28 12:04 ` [PATCH 19/21] git p4: avoid shell when invoking git config --get-all Pete Wyckoff
2012-09-28 12:04 ` [PATCH 20/21] git p4: avoid shell when calling git config Pete Wyckoff
2012-09-28 12:04 ` [PATCH 21/21] git p4: introduce gitConfigBool Pete Wyckoff
2012-09-28 19:17 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vr4pmkld7.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=pw@padd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).