From: Junio C Hamano <gitster@pobox.com>
To: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH] t/test-lib: print pretty msg when git isn't built
Date: Tue, 18 Sep 2012 01:00:17 -0700 [thread overview]
Message-ID: <7vr4pzoj5a.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <CALkWK0kbeLtU-5_9QnmQKS1yO02SvCW3ERvami9bmCa0Vym8oQ@mail.gmail.com> (Ramkumar Ramachandra's message of "Tue, 18 Sep 2012 12:47:42 +0530")
Ramkumar Ramachandra <artagnon@gmail.com> writes:
> Hi,
>
> Junio C Hamano wrote:
>> Ramkumar Ramachandra <artagnon@gmail.com> writes:
>>
>>> Hi Junio,
>>>
>>> Junio C Hamano wrote:
>>>> Is this a sufficient replacement for what you removed from 0000?
>>>> Can the BUILD-OPTIONS file exist when your build of git failed?
>>>
>>> Oops, I didn't realize that BUILD-OPTIONS would be written when the
>>> build fails. How about something like this instead:
>>
>> Yeah, but why change it so much? Wouldn't writing
>>
>> "$GIT_BUILD_DIR/git" >/dev/null
>> if test $? != 1
>> then
>> : You haven't built git!
>> fi
>>
>> just like the original in 0000 be sufficient??
>
> Because that emits an ugly
> ./test-lib.sh: 54: /home/artagnon/src/git/t/../git: not found
Don't you deserve it? ;-)
The full message would read
./test-lib.sh: 54: /home/artagnon/src/git/t/../git: not found
error: you do not seem to have built git yet.
which looks perfectly sensible to me. It makes it clear where on
the filesystem the test script expects your "git", which is an added
benefit.
next prev parent reply other threads:[~2012-09-18 8:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-17 17:06 [PATCH] t/perf: add "trash directory" to .gitignore Ramkumar Ramachandra
2012-09-17 17:06 ` [PATCH] t/test-lib: print pretty msg when git isn't built Ramkumar Ramachandra
2012-09-17 20:53 ` Junio C Hamano
2012-09-18 6:52 ` Ramkumar Ramachandra
2012-09-18 7:00 ` Junio C Hamano
2012-09-18 7:17 ` Ramkumar Ramachandra
2012-09-18 8:00 ` Junio C Hamano [this message]
2012-09-18 8:07 ` Ramkumar Ramachandra
2012-09-18 20:57 ` Junio C Hamano
2012-09-18 20:52 ` Junio C Hamano
2012-09-17 21:26 ` [PATCH] t/perf: add "trash directory" to .gitignore Junio C Hamano
2012-09-18 6:36 ` Ramkumar Ramachandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vr4pzoj5a.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).