From: Junio C Hamano <gitster@pobox.com>
To: demerphq <demerphq@gmail.com>
Cc: Subho Banerjee <subs.zero@gmail.com>,
Jonathan Nieder <jrnieder@gmail.com>,
Tim Henigan <tim.henigan@gmail.com>, git <git@vger.kernel.org>
Subject: Re: Git.pm
Date: Thu, 10 May 2012 09:20:29 -0700 [thread overview]
Message-ID: <7vr4usnh2q.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <CANgJU+W-FJZRtu_4si7nr96KfNe2rzaiUaDC0GiK_WixudvcxA@mail.gmail.com> (demerphq@gmail.com's message of "Thu, 10 May 2012 17:54:38 +0200")
demerphq <demerphq@gmail.com> writes:
> Similar logic for Try::Tiny. Why bother with it? It is pretty close to
> a fancy way to write eval { ...; 1 } or do { .... }; It is just one
> more module for people to misunderstand, and then make bugs with.
I personally like the approach to stick to bare "eval {}; if ($@) { ... }"
sequence, as it is much more explicit and easier to understand what is
happening underneath. IOW, I like what I read in demerphq's message.
But it could be that these many people who wrote these different
catch/throw things did so for a reason that I am missing, and if that is
the case, I am interested to hear what benefit we will get from using
them.
"It looks more familiar to people with (your favorite language)" could be
it, but then I would not regret missing such a reason ;-)
Thanks.
next prev parent reply other threads:[~2012-05-10 16:20 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-26 4:15 Git.pm Subho Banerjee
2012-04-26 18:41 ` Git.pm Randal L. Schwartz
2012-04-26 18:58 ` Git.pm Tim Henigan
2012-04-26 20:10 ` Git.pm Subho Banerjee
2012-04-26 20:31 ` Git.pm Jonathan Nieder
2012-05-10 13:19 ` Git.pm Subho Banerjee
2012-05-10 15:16 ` Git.pm Jonathan Nieder
2012-05-10 15:54 ` Git.pm demerphq
2012-05-10 16:18 ` Git.pm Subho Banerjee
2012-05-10 17:22 ` Git.pm demerphq
2012-05-10 16:20 ` Junio C Hamano [this message]
2012-05-10 17:38 ` Git.pm demerphq
2012-05-10 20:55 ` Git.pm Andrew Sayers
2012-05-11 8:27 ` Git.pm demerphq
2012-05-11 16:56 ` Git.pm Randal L. Schwartz
2012-05-11 18:10 ` Git.pm Junio C Hamano
2012-05-19 7:08 ` [PATCH][GIT.PM 1/3] Ignore files produced from exuberant-ctags Subho Sankar Banerjee
2012-05-19 7:08 ` [PATCH][GIT.PM 2/3] Getting rid of throwing Error::Simple objects in favour of simple Perl scalars which can be caught in eval{} blocks Subho Sankar Banerjee
2012-05-19 9:38 ` Andrew Sayers
2012-05-23 11:02 ` Subho Banerjee
2012-05-23 19:36 ` Andrew Sayers
2012-05-19 7:08 ` [PATCH][GIT.PM 3/3] Perl code uses eval{}/die instead of Error::Simple and Git::Error::Command Subho Sankar Banerjee
2012-04-26 19:17 ` Git.pm Junio C Hamano
2012-04-26 19:59 ` Git.pm Sam Vilain
-- strict thread matches above, loose matches on Subject: below --
2008-11-19 17:56 Git.pm nadim khemir
2008-11-20 8:34 ` Git.pm Petr Baudis
2008-11-20 13:07 ` Git.pm Petr Baudis
2008-11-23 19:58 ` Git.pm nadim khemir
2008-12-07 17:39 ` Git.pm nadim khemir
2008-11-21 2:56 ` Git.pm Jakub Narebski
2008-11-23 20:09 ` Git.pm nadim khemir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vr4usnh2q.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=demerphq@gmail.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=subs.zero@gmail.com \
--cc=tim.henigan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).