From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Clemens Buchacher <drizzd@aon.at>, git@vger.kernel.org
Subject: Re: [PATCH] fsck: do not print dangling objects by default
Date: Mon, 27 Feb 2012 11:29:53 -0800 [thread overview]
Message-ID: <7vr4xg6pn2.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20120227191846.GB1600@sigill.intra.peff.net> (Jeff King's message of "Mon, 27 Feb 2012 14:18:46 -0500")
Jeff King <peff@peff.net> writes:
>> Given that, isn't it not just sufficient but actually better to instead
>> add a new --no-dangling option and keep the default unchanged?
>
> ... Of course, it is fsck, so I wonder how often clueless people are
> really running it in the first place (i.e., it is not and should not be
> part of most users' typical workflows). If it is simply the case that
> they are being told to run "git fsck" by more expert users without
> understanding what it does, then I could buy the argument that those
> expert users could just as easily say "git fsck --no-dangling".
Yes, that was certainly part of my pros-and-cons analysis. If you run
"git fsck" without "--no-dangling" without reading the manual, you may
get confused, but that is *not* the primary audience. People who are
curious can read the manual and figure it out, and the need for "fsck" is
much rarer these days, compared to 2005 ;-)
In that context, only large downsides of potentially breaking and having
to adjust existing scripts remains without much upsides, if we were to
switch the default.
next prev parent reply other threads:[~2012-02-27 19:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-26 20:43 [PATCH] fsck: do not print dangling objects by default Clemens Buchacher
2012-02-26 21:57 ` Junio C Hamano
2012-02-26 22:46 ` Junio C Hamano
2012-02-27 6:42 ` Zbigniew Jędrzejewski-Szmek
2012-02-27 19:18 ` Jeff King
2012-02-27 19:29 ` Junio C Hamano [this message]
2012-02-27 21:13 ` Clemens Buchacher
2012-02-27 21:33 ` Jeff King
2012-02-27 22:18 ` Clemens Buchacher
2012-02-27 21:34 ` Junio C Hamano
2012-02-28 23:25 ` [PATCH] fsck: --no-dangling omits "dangling object" information Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vr4xg6pn2.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=drizzd@aon.at \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).