From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "Jonathan Nieder" <jrnieder@gmail.com>,
"Thomas Rast" <trast@student.ethz.ch>,
git@vger.kernel.org, "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
"Michael Haggerty" <mhagger@alum.mit.edu>
Subject: Re: tr/pty-all (Re: What's cooking in git.git (Dec 2011, #04; Tue, 13))
Date: Thu, 15 Dec 2011 10:19:33 -0800 [thread overview]
Message-ID: <7vr505ofyi.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20111215065529.GA1327@sigill.intra.peff.net> (Jeff King's message of "Thu, 15 Dec 2011 01:55:29 -0500")
Jeff King <peff@peff.net> writes:
> On Wed, Dec 14, 2011 at 07:23:14PM -0800, Junio C Hamano wrote:
>
>> Jeff King <peff@peff.net> writes:
>>
>> > This correctly detects the bug in t7006. I can't decide if it's clever
>> > or ugly.
>>
>> I would say it falls on the latter side of the line by small margin. Let's
>> do the /dev/null thing and be done with it.
>
> Darn, I wanted to post it on my fridge with an "A+".
Heh.
If it were without the perl "tell" bits, it would have been "clever and
clean", perhaps like
arrange the following to read from t/random-stdin file
- run the test script
- "read x"
compare the $x you just read with t/random-stdin file
But I think it is good enough to be stupid and clean.
> Here's a cleaned-up version of the /dev/null one.
Thanks.
prev parent reply other threads:[~2011-12-15 18:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-14 1:19 What's cooking in git.git (Dec 2011, #04; Tue, 13) Junio C Hamano
2011-12-14 7:09 ` tr/pty-all (Re: What's cooking in git.git (Dec 2011, #04; Tue, 13)) Jonathan Nieder
2011-12-14 16:17 ` Thomas Rast
2011-12-14 17:42 ` Junio C Hamano
2011-12-14 23:07 ` Jeff King
2011-12-14 23:21 ` Jeff King
2011-12-14 23:31 ` Jonathan Nieder
2011-12-15 0:25 ` Jeff King
2011-12-15 0:50 ` Jeff King
2011-12-15 3:23 ` Junio C Hamano
2011-12-15 6:55 ` Jeff King
2011-12-15 18:19 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vr505ofyi.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=mhagger@alum.mit.edu \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).