From: Junio C Hamano <gitster@pobox.com>
To: Martin von Zweigbergk <martin.von.zweigbergk@gmail.com>
Cc: git@vger.kernel.org, Michael Witten <mfwitten@gmail.com>,
anikey <arty.anikey@gmail.com>
Subject: Re: Git Bug - diff in commit message.
Date: Tue, 25 Oct 2011 07:11:33 -0700 [thread overview]
Message-ID: <7vr52140ve.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <CAOeW2eG_muSdbWUaPG36=1-Ay6h6-4qHgWPNdjqY5Zpb52XisQ@mail.gmail.com> (Martin von Zweigbergk's message of "Mon, 24 Oct 2011 16:24:15 -0700")
Martin von Zweigbergk <martin.von.zweigbergk@gmail.com> writes:
>> And here is a quick hack to do that using "log --cherry-pick --right-only".
>
> Thanks. I had done something similar. I have now adopted most of your
> changes into my patches, but I have a few questions.
It was a quick hack and not necessarily well thought out.
> Are these braces needed?
Probably not.
> In your previous mail in this thread, this was
> ...
> I see why you dropped "-m --first-parent"; we should simply never
> receive such patches to "git-am --rebasing". But why isn't --binary
> necessary?
It may be; I somehow thought we made it a no-op but didn't check.
> Why was this part left out?
No particular reason other than I was not looking at the earlier "how
about this" patch closely. It may be needed, it may not be, I dunno, and I
didn't check when I wrote this second quick hack.
Thanks.
next prev parent reply other threads:[~2011-10-25 14:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-08 14:49 Git Bug - diff in commit message anikey
2011-09-08 16:26 ` Michael Witten
2011-09-09 0:56 ` Thomas Rast
2011-09-09 6:14 ` Johannes Sixt
2011-09-09 16:00 ` Junio C Hamano
2011-10-11 23:00 ` Junio C Hamano
2011-10-24 23:24 ` Martin von Zweigbergk
2011-10-25 14:11 ` Junio C Hamano [this message]
2011-09-08 17:27 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vr52140ve.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=arty.anikey@gmail.com \
--cc=git@vger.kernel.org \
--cc=martin.von.zweigbergk@gmail.com \
--cc=mfwitten@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).