From: Junio C Hamano <gitster@pobox.com>
To: Alex Neronskiy <zakmagnus@google.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Document the underlying protocol used by shallow repositories and --depth commands.
Date: Tue, 07 Jun 2011 15:05:00 -0700 [thread overview]
Message-ID: <7vr57547sj.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <loom.20110607T224355-216@post.gmane.org> (Alex Neronskiy's message of "Tue, 7 Jun 2011 20:47:34 +0000 (UTC)")
Alex Neronskiy <zakmagnus@google.com> writes:
> The part of the document I'm referring to starts at line 221 and reads:
>
> Once all the "want"s (and optional 'deepen') are transferred,
> clients MUST send a flush-pkt. If the client has all the references
> on the server, client flushes and disconnects.
>
> And I believe this refers to the code path beginning at line 308 of fetch-pack.c:
>
> if (!fetching) {
> strbuf_release(&req_buf);
> packet_flush(fd[1]);
> return 1;
> }
>
> Am I wrong?
Ah, I overlooked that codepath, but if that if statement triggered, that
would mean fetching is still 0, which in turn means that you never sent
any "want", so "Once all the 'want's' (and optional 'deepen') are
transferred" is not even true, is it?
next prev parent reply other threads:[~2011-06-07 22:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-06 17:26 [PATCH] Document the underlying protocol used by shallow repositories and --depth commands Alexander Neronskiy
2011-06-06 18:21 ` Junio C Hamano
2011-06-06 19:56 ` Alex Neronskiy
2011-06-07 20:23 ` Junio C Hamano
2011-06-07 20:47 ` Alex Neronskiy
2011-06-07 22:05 ` Junio C Hamano [this message]
2011-06-07 22:31 ` Alex Neronskiy
2011-06-07 23:01 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vr57547sj.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=zakmagnus@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).