From: Junio C Hamano <gitster@pobox.com>
To: "J.H." <warthog9@kernel.org>
Cc: Jakub Narebski <jnareb@gmail.com>,
git@vger.kernel.org, Drew Northup <drew.northup@maine.edu>,
Petr Baudis <pasky@suse.cz>
Subject: Re: [PATCH 0/2] gitweb: Improve handling of configuration files
Date: Wed, 25 May 2011 12:34:25 -0700 [thread overview]
Message-ID: <7vr57m377i.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <4DDD4CC1.3070103@kernel.org> (J. H.'s message of "Wed, 25 May 2011 11:38:57 -0700")
"J.H." <warthog9@kernel.org> writes:
> I would argue against this, for a couple of reasons:
>
> 1) Git itself treats /etc/git.conf in this exact manor,...
> Case in point turning on things like updateserverinfo, or automatic packing.
If we read both from the beginning of time it would have been more
convenient, and I agree with that 100%. So this is not a valid reason to
"argue against this".
> 2) Trying to get people to do includes in their config files, or to
> completely ignore the system wide config isn't a sustainable practice.
I also agree with this.
In any case, I do not think we have to choose between Jakub's two patches.
prev parent reply other threads:[~2011-05-25 19:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-25 16:35 [PATCH 0/2] gitweb: Improve handling of configuration files Jakub Narebski
2011-05-25 16:35 ` [PATCH 1/2] gitweb: Refactor reading and parsing config file into read_config_file Jakub Narebski
2011-05-25 19:36 ` Junio C Hamano
2011-05-25 16:35 ` [PATCHv1 2/2 (version A)] gitweb: Mention read_config_file in gitweb/README Jakub Narebski
2011-05-25 16:35 ` [PATCHv3 2/2 (version B)] gitweb: Use /etc/gitweb.conf even if gitweb_conf.perl exist Jakub Narebski
2011-05-25 18:54 ` Junio C Hamano
2011-05-26 14:58 ` [PATCH/RFC 2/2 (version C)] gitweb: Introduce common system-wide settings for convenience Jakub Narebski
2011-05-25 18:38 ` [PATCH 0/2] gitweb: Improve handling of configuration files J.H.
2011-05-25 19:34 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vr57m377i.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=drew.northup@maine.edu \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=pasky@suse.cz \
--cc=warthog9@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).