From: Junio C Hamano <gitster@pobox.com>
To: Kevin Ballard <kevin@sb.org>
Cc: Git mailing list <git@vger.kernel.org>
Subject: Re: [PATCH 2/2] rebase: teach --autosquash to match on sha1 in addition to message
Date: Thu, 04 Nov 2010 12:09:32 -0700 [thread overview]
Message-ID: <7vr5f0vrbn.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <5CCA000B-2178-4DF7-8D72-29F95A9BB360@sb.org> (Kevin Ballard's message of "Wed\, 3 Nov 2010 21\:49\:10 -0700")
Kevin Ballard <kevin@sb.org> writes:
> On Nov 3, 2010, at 7:41 PM, Kevin Ballard wrote:
>
>> Support lines of the form "fixup! 7a235b" that specify an exact commit
>> in addition to the normal "squash! Old commit message" form.
>
> I just realized that this only works for sha1's of up to 7 characters.
> If you provide more it won't match, as it's comparing against the sha1
> given in the todo list. I wonder if it's worth resolving all sha1s to
> their full length if the provided string is longer than 7 characters?
Yeah, this is a nice feature I sometimes missed ;-)
next prev parent reply other threads:[~2010-11-04 19:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-04 2:41 [PATCH 1/2] rebase: better rearranging of fixup!/squash! lines with --autosquash Kevin Ballard
2010-11-04 2:41 ` [PATCH 2/2] rebase: teach --autosquash to match on sha1 in addition to message Kevin Ballard
2010-11-04 4:49 ` Kevin Ballard
2010-11-04 10:44 ` Sverre Rabbelier
2010-11-04 21:35 ` Kevin Ballard
2010-11-04 19:09 ` Junio C Hamano [this message]
2010-11-04 22:36 ` [PATCHv2 1/2] rebase: better rearranging of fixup!/squash! lines with --autosquash Kevin Ballard
2010-11-04 22:36 ` [PATCHv2 2/2] rebase: teach --autosquash to match on sha1 in addition to message Kevin Ballard
2010-11-05 13:04 ` [PATCH " Peter Krefting
2010-11-08 10:48 ` [PATCHv3 1/2] rebase: better rearranging of fixup!/squash! lines with --autosquash Kevin Ballard
2010-11-08 10:52 ` Yann Dirson
2010-11-08 11:10 ` Kevin Ballard
2010-11-08 10:48 ` [PATCHv3 2/2] rebase: teach --autosquash to match on sha1 in addition to message Kevin Ballard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vr5f0vrbn.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=kevin@sb.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).