From: Junio C Hamano <gitster@pobox.com>
To: Elijah Newren <newren@gmail.com>
Cc: git@vger.kernel.org, pclouds@gmail.com
Subject: Re: [PATCHv2 0/8] Make rev-list --objects work with pathspecs; minor optimizations
Date: Fri, 27 Aug 2010 10:28:24 -0700 [thread overview]
Message-ID: <7vr5hkhsnb.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: 1282803711-10253-1-git-send-email-newren@gmail.com
Elijah Newren <newren@gmail.com> writes:
> This series enables rev-list to produce a list of objects that is path
> limited, when the user requests it. It also provides a few small code
> cleanups and some small optimizations.
A cursory look didn't spot anything glaringly wrong ;-)
I'd split 3-6 into a separate "tree-walk-optim" topic and keep the first
two as "object-list-with-pathspec" topic. They really look independent.
Thanks.
prev parent reply other threads:[~2010-08-27 17:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-26 6:21 [PATCHv2 0/8] Make rev-list --objects work with pathspecs; minor optimizations Elijah Newren
2010-08-26 6:21 ` [PATCHv2 1/8] Add testcases showing how pathspecs are ignored with rev-list --objects Elijah Newren
2010-08-26 6:21 ` [PATCHv2 2/8] Make rev-list --objects work together with pathspecs Elijah Newren
2010-08-26 6:21 ` [PATCHv2 3/8] Document pre-condition for tree_entry_interesting Elijah Newren
2010-08-26 6:21 ` [PATCHv2 4/8] tree-walk: Correct bitrotted comment about tree_entry() Elijah Newren
2010-08-26 6:21 ` [PATCHv2 5/8] tree_entry_interesting(): Make return value more specific Elijah Newren
2010-08-26 6:21 ` [PATCHv2 6/8] diff_tree(): Skip skip_uninteresting() when all remaining paths interesting Elijah Newren
2010-08-26 6:21 ` [PATCHv2 7/8] list-objects.c: Avoid recomputing interesting-ness for subtrees when possible Elijah Newren
2010-08-26 6:21 ` [PATCHv2 8/8] tree-diff.c: " Elijah Newren
2010-08-27 17:28 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vr5hkhsnb.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=newren@gmail.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).