From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Brian Gernhardt <brian@gernhardtsoftware.com>,
Git List <git@vger.kernel.org>
Subject: Re: [PATCH] t9302: Protect against OS X normalization
Date: Mon, 08 Feb 2010 23:05:19 -0800 [thread overview]
Message-ID: <7vr5ouopn4.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20100209065845.GA6503@sigill.intra.peff.net> (Jeff King's message of "Tue\, 9 Feb 2010 01\:58\:45 -0500")
Jeff King <peff@peff.net> writes:
> On Mon, Feb 08, 2010 at 10:53:49PM -0800, Junio C Hamano wrote:
>
>> I think there is no reliable reproduction recipe for this, as we don't
>> control what garbage is in the tail of malloc'ed memory; valgrind would
>> have found it, though.
>>
>> Let's revert the test part of the patch.
>
> IMHO, valgrind finding it is reason enough to keep it. We do run the
> test suite against valgrind from time to time, and clearly this code
> path was not being exercised prior to this (or my previous valgrind runs
> would have caught it).
>
> I think Brian's patch is the best thing to do.
Having Brian's patch would not hurt, and it definitely is an improvement
than using a name OSX cannot cope with, so I'll apply it nevertheless.
FWIW, neither the updated test nor your French test does not trigger for
me after reverting the "quote.c" part from 8424981 without valgrind.
Thanks for helping me think this through.
prev parent reply other threads:[~2010-02-09 7:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-09 3:38 OS X Unicode Normalization Hits Again Brian Gernhardt
2010-02-09 3:44 ` Junio C Hamano
2010-02-09 4:07 ` [PATCH] t9302: Protect against OS X normalization Brian Gernhardt
2010-02-09 6:08 ` Jeff King
2010-02-09 6:14 ` Jeff King
2010-02-09 6:53 ` Junio C Hamano
2010-02-09 6:58 ` Jeff King
2010-02-09 7:05 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vr5ouopn4.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=brian@gernhardtsoftware.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).